[IMP] estate: added sql constraints and python constraints, fixed offer view

[FIX] estate: code formatting and rename compute method

Improved code readability by applying consistent formatting.
Renamed compute method for best_price to follow naming conventions. changed discription position after name in manifest file.

Author: danal-odoo

estate/__manifest__.py

@@ -1,15 +1,15 @@
 #!/usr/bin/env python3
 {
     "name": "Real Estate",
+    "description": """
+    Real Estate Module to Buy and Sell Your Real Estate with Ease.
+    """,
     "version": "1.0",
     "depends": ["base"],
     "author": "danal",
     "category": "Category",
     "application": True,
     "license": "LGPL-3",
-    "description": """
-    Real Estate Module to Buy and Sell Your Real Estate with Ease.
-    """,
     "data": [
         "security/ir.model.access.csv",
         "views/estate_property_views.xml",

estate/models/estate_property.py

@@ -1,14 +1,21 @@
 #!/usr/bin/env python3
 from dateutil.relativedelta import relativedelta
+from odoo.exceptions import ValidationError
 
 from odoo import api, models, fields, exceptions
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate Property"
+    _check_expected_price = models.Constraint(
+        "CHECK(expected_price > 0)", "A property expected price must be strictly positive."
+    )
+    _check_selling_price = models.Constraint(
+        "CHECK(selling_price >= 0)", "A property selling price must be positive."
+    )
 
-    name = fields.Char(required=True, default="Unknown")
+    name = fields.Char(required=True)
     description = fields.Text()
     postcode = fields.Char()
     date_avaliability = fields.Date(
@@ -22,7 +29,6 @@ class EstateProperty(models.Model):
     garage = fields.Boolean()
     garden = fields.Boolean()
     garden_area = fields.Integer()
-    last_seen = fields.Datetime("Last Seen", default=fields.Datetime.now)
     garden_orientation = fields.Selection(
         selection=[
             ("north", "North"),
@@ -54,15 +60,15 @@ class EstateProperty(models.Model):
     tag_ids = fields.Many2many("estate.property.tag", string="Property Tags")
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offer")
     total_area = fields.Integer(compute="_compute_area")
-    best_price = fields.Integer(compute="_compute_highest")
+    best_price = fields.Integer(compute="_compute_best_price")
 
     @api.depends("living_area", "garden_area")
     def _compute_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
     @api.depends("offer_ids.price")
-    def _compute_highest(self):
+    def _compute_best_price(self):
         for record in self:
             if not record.mapped("offer_ids.price"):
                 record.best_price = 0
@@ -76,6 +82,7 @@ def _onchange_garden(self):
             self.garden_orientation = "north"
         else:
             self.garden_area = 0
+            self.garden_orientation = None
 
     def action_sold_property(self):
         for record in self:
@@ -92,3 +99,16 @@ def action_cancel_offer(self):
             else:
                 record.state = "cancelled"
         return True
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price_persentage(self):
+        for record in self:
+            selling_price_persentage = (
+                record.selling_price / record.expected_price
+            ) * 100
+            if selling_price_persentage >= 90 or selling_price_persentage == 0:
+                pass
+            else:
+                raise ValidationError(
+                    "The selling price cannot be lower than 90% of the expected price."
+                )

estate/models/estate_property_offer.py

@@ -6,6 +6,9 @@
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate Property Offer"
+    _check_offer_price = models.Constraint(
+        "CHECK(price > 0)", "An offer price must be strictly positive"
+    )
 
     price = fields.Float()
     status = fields.Selection(
@@ -41,6 +44,5 @@ def action_accept(self):
     def action_refuse(self):
         for record in self:
             record.status = "refused"
-            record.property_id.selling_price = 0.00
             record.property_id.customer = None
         return True

estate/models/estate_property_tag.py

@@ -4,5 +4,8 @@
 class EstatePropertyTags(models.Model):
     _name = "estate.property.tag"
     _description = "Estate Property Tag"
+    _check_tag_name = models.Constraint(
+        "UNIQUE(name)", "A property tag name should be unique."
+    )
 
     name = fields.Char(required=True)

estate/models/estate_property_type.py

@@ -5,5 +5,8 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type"
+    _check_type_name = models.Constraint(
+        "UNIQUE(name)", "A property type name should be unique."
+    )
 
     name = fields.Char(required=True)

estate/views/estate_property_views.xml

@@ -118,8 +118,8 @@
                 <field name="partner_id"/>
                 <field name="validity" string="Validity(days)"/>
                 <field name="date_deadline"/>
-                <button name="action_accept" string="Accept" type="object" icon="fa-check"/>
-                <button name="action_refuse" string="Refuse" type="object" icon="fa-times"/>        
+                <button name="action_accept" string="Accept" type="object" icon="fa-check" invisible="status in ('accepted', 'refused')"/>
+                <button name="action_refuse" string="Refuse" type="object" icon="fa-times" invisible="status in ('accepted', 'refused')"/>        
                 <field name="status"/>
             </list>
         </field>