[IMP] estate: Implemented constraints for price validation

-Refactored validity field to validity_days
-added constraints for price validation

Author: hapat-odoo

Estate/models/estate_property.py

@@ -1,5 +1,6 @@
 from odoo import models, fields, api
 from datetime import timedelta
+from odoo.exceptions import ValidationError
 
 
 class EstateProperty(models.Model):
@@ -39,11 +40,9 @@ class EstateProperty(models.Model):
     salesperson_id = fields.Many2one("res.users", string="Salesperson")
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
-
     total_area = fields.Float(compute="_compute_total_area", string="Total Area", store=True)
     best_price = fields.Float(compute="_compute_best_price", string="Best Offer", store=True)
-
-    validity = fields.Integer(default=7)
+    validity_days = fields.Integer(default=7)
     date_deadline = fields.Date(
         compute="_compute_date_deadline",
         inverse="_inverse_date_deadline",
@@ -60,21 +59,21 @@ def _compute_best_price(self):
         for record in self:
             record.best_price = max(record.offer_ids.mapped("price")) if record.offer_ids else 0.0
 
-    @api.depends("create_date", "validity")
+    @api.depends("create_date", "validity_days")
     def _compute_date_deadline(self):
         for record in self:
             create_date = record.create_date or fields.Date.today()
             if hasattr(create_date, "date"):
                 create_date = create_date.date()
-            record.date_deadline = create_date + timedelta(days=record.validity)
+            record.date_deadline = create_date + timedelta(days=record.validity_days)
 
     def _inverse_date_deadline(self):
         for record in self:
             create_date = record.create_date or fields.Date.today()
             if hasattr(create_date, "date"):
                 create_date = create_date.date()
             delta = (record.date_deadline - create_date).days if record.date_deadline else 0
-            record.validity = delta
+            record.validity_days = delta
 
     @api.onchange("garden")
     def _onchange_garden(self):
@@ -106,3 +105,23 @@ def action_set_next_status(self):
     def action_back_to_new(self):
         for record in self:
             record.state = "new"
+
+    @api.constrains("selling_price","expected_price")
+    def _check_selling_price_ratio(self):
+        for record in self:
+            if record.selling_price <= 0:
+                raise ValidationError("Selling price must be greater than or equal to 0")
+            if  record.selling_price < 0.9 * record.expected_price:
+                raise ValidationError("Selling price must be at least 90% of the expected price")
+            if record.expected_price < 0:
+                raise ValidationError("Expected price must be greater than 0")
+
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price < 0)',
+        'The expected price of a property must be strictly positive.'
+    )
+
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price < 0)',
+        'The selling price of a property must be positive.'
+    )

Estate/models/estate_property_offer.py

@@ -1,4 +1,5 @@
-from odoo import models, fields
+from odoo import models, fields, api
+from odoo.exceptions import ValidationError
 
 
 class EstatePropertyOffer(models.Model):
@@ -23,3 +24,13 @@ def action_accept_offer(self):
     def action_refuse_offer(self):
         for record in self:
             record.status = 'refused'
+    @api.constrains("price")
+    def _check_price_ratio(self):
+        for record in self:
+            if record.price <= 0.0:
+                raise ValidationError("Price must be greater than 0")
+
+    _check_price = models.Constraint(
+        'CHECK(price < 0)',
+        'The price must be strictly positive.'
+    )

Estate/views/estate_property_views.xml

@@ -71,7 +71,7 @@
                         <field name="best_price" readonly="1"/>
                         <field name="state"/>
                         <field name="validity_days"/>
-                        <field name= "deadline_date"/>
+                        <field name= "date_deadline"/>
                     </group>
 
                 </group>
@@ -127,4 +127,4 @@
     </record>
 
 
-</odoo>
+</odoo>