[IMP] estate: add constraints in model

add SQL and Python both type constraints in database

Author: utpat-odoo

estate/__init__.py

@@ -1 +1 @@
-from . import models 
+from . import models

estate/__manifest__.py

@@ -1,14 +1,15 @@
 {
+    'author': 'Odoo S.A.',
     'name': 'Estate',
     'depends': ['base'],
-    'license': 'AGPL-3',
+    'license': 'LGPL-3',
     'data': [
         'security/ir.model.access.csv',
         'views/estate_property_views.xml',
-        'views/estate_menus.xml',
         'views/estate_property_type_views.xml',
         'views/estate_property_tag_views.xml',
-        'views/estate_property_offer_views.xml'
+        'views/estate_property_offer_views.xml',
+        'views/estate_menus.xml'
         ],
     'application': True,
     'installable': True

estate/models/estate_property.py

@@ -1,6 +1,7 @@
 from odoo import models, fields, api
 from dateutil.relativedelta import relativedelta
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare
 
 
 class EstateProperty(models.Model):
@@ -22,8 +23,8 @@ class EstateProperty(models.Model):
     garden_orientation = fields.Selection(
         string="Garden Orientation",
         selection=[('north', 'North'),
-        ('south', 'South'), 
-        ('east', 'East'), 
+        ('south', 'South'),
+        ('east', 'East'),
         ('west', 'West')
         ]
     )
@@ -42,14 +43,14 @@ class EstateProperty(models.Model):
     salesperson = fields.Many2one("res.users", default=lambda self: self.env.user)
     tag_ids = fields.Many2many("estate.property.tag")
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
-
     total_area = fields.Float(compute="_compute_total_area")
+    best_offer = fields.Float(compute="_compute_best_offer")
+    
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
-    best_offer = fields.Float(compute="_compute_best_offer")
     @api.depends('offer_ids.price')
     def _compute_best_offer(self):
         for record in self:
@@ -79,5 +80,16 @@ def sold_property(self):
             if record.state == 'cancelled':
                 raise UserError("cancelled property cannot be sold.")
             else:
-                record.state = 'sold'
-            
+                record.state = 'sold' 
+
+    _sql_constraints = [
+        ('check_expected_price', 'CHECK(expected_price>=0)', 'expected price must be positive'),
+        ('check_selling_price', 'CHECK(selling_price>=0)', 'selling price must be positive')
+    ]
+
+    @api.constrains('selling_price',  'expected_price', 'state')
+    def _check_selling_price(self):
+        for record in self:
+            if float_compare(record.selling_price, 0.9 * record.expected_price, precision_digits=2) < 0 and (record.state == 'sold' or record.state == 'offer_accepted'):
+                raise ValidationError("the selling price is lower")
+                

estate/models/estate_property_offer.py

@@ -1,14 +1,14 @@
-from odoo import models,fields, api
+from odoo import models, fields, api
 from dateutil.relativedelta import relativedelta
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
 
 
 class EstatePropertyOffer(models.Model):
-    _name='estate.property.offer'
-    _description="Estate Property Offer"
+    _name = 'estate.property.offer'
+    _description = "Estate Property Offer"
 
-    price=fields.Float()
-    status=fields.Selection(
+    price = fields.Float()
+    status = fields.Selection(
         selection=[
             ('accepted', 'Accepted'),
             ('refused', 'Refused')
@@ -30,7 +30,7 @@ def _compute_deadline(self):
     def _inverse_deadline(self):
         for record in self:
             if record.create_date:
-                record.validity = (record.date_deadline - fields.Date.to_date(record.create_date)).days 
+                record.validity = (record.date_deadline - fields.Date.to_date(record.create_date)).days
             else:
                 record.validity = 0
 
@@ -46,5 +46,7 @@ def action_accept(self):
 
     def action_refuse(self):
         for record in self:
-            record.status = 'refused'
-    
+            if record.status == 'accepted':
+                raise UserError("Property already accepted")
+            else: 
+                record.status = 'refused'

estate/models/estate_property_tag.py

@@ -2,9 +2,12 @@
 
 
 class EstatePropertyTag(models.Model):
-    _name='estate.property.tag'
-    _description="Estate Property Tag"
+    _name = 'estate.property.tag'
+    _description = "Estate Property Tag"
 
-    name=fields.Char()
+    name = fields.Char()
     property_ids = fields.Many2many('estate.property')
-    
+    
+    _sql_constraints = [
+        ('unique_name', 'UNIQUE(name)', 'name already exists!')
+    ]

estate/models/estate_property_type.py

@@ -5,5 +5,9 @@ class EstatePropertyType(models.Model):
     _name = 'estate.property.type' 
     _description = "Real Estate Property Type"
 
-    name = fields.Char(required=True) 
-    property_ids = fields.One2many('estate.property','property_type_id')
+    name = fields.Char(required=True)
+    property_ids = fields.One2many('estate.property', 'property_type_id')
+
+    _sql_constraints = [
+        ('unique_name', 'UNIQUE(name)', 'name already exists!'),
+    ]