Skip to content

[FIX] do not error on SQL data files #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmahrouss wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

[FIX] do not error on SQL data files #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/core/diagnostic_codes_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ OLS05048, DiagnosticSetting::Error, "Invalid child node {0} in function node",
OLS05049, DiagnosticSetting::Error, "Data file {0} not found in the module",
/**
*/
OLS05050, DiagnosticSetting::Error, "Data file {0} is not a valid XML or CSV file",
OLS05050, DiagnosticSetting::Error, "Data file {0} is not a valid XML, CSV, or SQL file",
/**
* An XML_ID should be in the format 'xml_id' or 'module.xml_id', but can't contains more dots
*/
Expand Down
2 changes: 1 addition & 1 deletion server/src/core/symbols/module_symbol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ impl ModuleSymbol {
..diagnostic.clone()
});
}
} else if path.extension().map_or(true, |ext| !["xml", "csv"].contains(&ext.to_str().unwrap_or(""))) {
} else if path.extension().map_or(true, |ext| !["xml", "csv", "sql"].contains(&ext.to_str().unwrap_or(""))) {
if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05050, &[&path.sanitize()]) {
diagnostics.push(Diagnostic {
range: Range::new(Position::new(data_range.start().to_u32(), 0), Position::new(data_range.end().to_u32(), 0)),
Expand Down