Skip to content

Farmer's Hat reduces price to 1 for combined trades #467

@Archer6621

Description

@Archer6621

Bug description

I noticed that sometimes the trade advantage for the Farmer's Hat would be much more for certain trades than some others.

In particular, trades with librarians that involve a book + some emeralds always result in a price of 1 emerald (even if it costs 17 emeralds + 1 book). It's almost as if it is using the wrong quantity/item to reduce the price. This seems to hold for other trades that involve 2 items as well.

Here's a screenshot:
Image

As can be seen, certain other trades also get reduced to 1 item (e.g. the ink sacs), but those seem more plausible than what is going on with the enchantment trades. Notice how the name tag seems fine, quite a discount but nothing crazy. Taking the hat off makes prices go back to normal values for those book + emerald trades, with just a couple of emeralds discount from reputation.

I am playing with the experimental changes to trades enabled, not sure if that would impact it. Not playing with any other mods that would affect trades AFAIK.

Steps to reproduce

  1. Find a librarian to trade with (e.g. place a lectern somewhere in a village)
  2. Level it up until it offers trades requiring a book + emeralds for an enchanted book
  3. Equip Farmer's Hat
  4. ???
  5. Profit

Artifacts version

14.0.3

Mod loader

Fabric

Mod loader version

0.18.4

Accessory mod

Trinkets updated

Accessory mod version

trinkets-3.11.0-beta.2+

Additional Details

This is on Minecraft 1.21.11.

Trinkets mod is this updated fork: https://modrinth.com/mod/trinkets-updated?version=1.21.11&loader=fabric

Log with mods: latest.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working. Whoops

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions