Merge pull request #25 from objectwow/dev

fix: wrong from param and asMap interface

Author: vtuanjs

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@objectwow/join",
-  "version": "0.3.5",
+  "version": "0.3.6",
   "license": "MIT",
   "description": "Perform a deep join of arrays of objects using UIDs.",
   "publishConfig": {

src/type.ts

@@ -6,10 +6,12 @@ export type LocalParam = object | object[];
 
 export type FromParam =
   | ((localFieldValues: Primitive[], metadata: any) => object[])
+  | ((localFieldValues: Primitive[], metadata: any) => Promise<object[]>)
   | object[];
 
 export type AsMap =
   | ((currentFrom: any, currentLocal: any, metadata: any) => any)
+  | ((currentFrom: any, currentLocal: any, metadata: any) => Promise<any>)
   | { [key: string]: string }
   | string;
 

tests/core.spec.ts

@@ -64,13 +64,15 @@ describe("JoinData - execute method full coverage", () => {
   });
 
   it("should merge entire from objects into each local array element when as and asMap are undefined", async () => {
-    const fromFn = async () => [
-      { id: 1, name: "Alice", age: 25 },
-      { id: 2, name: "Bob", age: 30 },
-    ];
-
     const param: JoinDataParam = {
-      from: await fromFn(),
+      from: async () => {
+        const result = [
+          { id: 1, name: "Alice", age: 25 },
+          { id: 2, name: "Bob", age: 30 },
+        ] as unknown as Promise<object[]>;
+
+        return result;
+      },
       local: [{ id: 1 }, { id: 2 }],
       localField: "id",
       fromField: "id",