feat(links): Open non-editable links with vim.ui.open

Links that are not editable in Neovim are now opened with `vim.ui.open`,
like pdfs, images, or anything else that cannot be detected with
`vim.filetype.match`.

Closes #905

Author: kristijanhusak

lua/orgmode/org/links/types/http.lua

@@ -26,17 +26,7 @@ function OrgLinkHttp:follow(link)
     return false
   end
 
-  if vim.ui['open'] then
-    vim.ui.open(url)
-    return true
-  end
-
-  if not vim.g.loaded_netrwPlugin then
-    utils.echo_warning('Netrw plugin must be loaded in order to open urls.')
-    return false
-  end
-
-  vim.fn['netrw#BrowseX'](url, vim.fn['netrw#CheckIfRemote']())
+  vim.ui.open(url)
   return true
 end
 

lua/orgmode/org/links/utils.lua

@@ -1,10 +1,27 @@
 local utils = require('orgmode.utils')
 local link_utils = {}
 
+local external_filetypes = {
+  -- pdf is considered a valid filetype even though it cannot be correctly read
+  'pdf',
+}
+
+---@param filename string
+---@return boolean - if editable, returns true, otherwise false
+local function edit_file(filename)
+  local filetype = vim.filetype.match({ filename = filename })
+  if not filetype or vim.tbl_contains(external_filetypes, filetype) then
+    vim.ui.open(filename)
+    return false
+  end
+  vim.cmd(('edit %s'):format(filename))
+  return true
+end
+
 ---@param file OrgFile
 ---@return boolean
 function link_utils.goto_file(file)
-  vim.cmd(('edit %s'):format(file.filename))
+  edit_file(file.filename)
   return true
 end
 
@@ -54,7 +71,11 @@ function link_utils.open_file_and_search(file_path, search_text)
     return true
   end
   if file_path ~= utils.current_file_path() then
-    vim.cmd(('edit %s'):format(file_path))
+    local editable = edit_file(file_path)
+    -- Return without attempt to find text. File is not editable.
+    if not editable then
+      return true
+    end
   end
 
   if not search_text or search_text == '' then