Skip to content

Commit ba503e5

Browse files
committed
disable credential verification on wallet.List()
1 parent ed621e8 commit ba503e5

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

vcr/holder/sql_wallet.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ package holder
2020

2121
import (
2222
"context"
23-
"errors"
2423
"fmt"
2524
"time"
2625

@@ -128,13 +127,15 @@ func (h sqlWallet) List(_ context.Context, holderDID did.DID) ([]vc.VerifiableCr
128127
// now validate credentials and remove invalid ones
129128
validCredentials := make([]vc.VerifiableCredential, 0, len(credentials))
130129
for _, credential := range credentials {
130+
validCredentials = append(validCredentials, credential)
131+
// TODO: Disabled for now in project GF, because we want to actively demo with expired credentials.
131132
// we only want to check expiration and revocation status
132-
if err = h.verifier.Verify(credential, true, false, nil); err == nil {
133-
validCredentials = append(validCredentials, credential)
134-
} else if !errors.Is(err, types.ErrCredentialNotValidAtTime) && !errors.Is(err, types.ErrRevoked) {
135-
// a possible technical error has occurred that should be logged.
136-
log.Logger().WithError(err).WithField(core.LogFieldCredentialID, credential.ID).Warn("unable to verify credential")
137-
}
133+
//if err = h.verifier.Verify(credential, true, false, nil); err == nil {
134+
// validCredentials = append(validCredentials, credential)
135+
//} else if !errors.Is(err, types.ErrCredentialNotValidAtTime) && !errors.Is(err, types.ErrRevoked) {
136+
// // a possible technical error has occurred that should be logged.
137+
// log.Logger().WithError(err).WithField(core.LogFieldCredentialID, credential.ID).Warn("unable to verify credential")
138+
//}
138139
}
139140

140141
return validCredentials, nil

0 commit comments

Comments
 (0)