fix: IOReader::decrement_depth can underflow while SliceReader guards against zero#33
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a depth-tracking bug in the IOReader implementation by aligning its decrement_depth behavior with SliceReader, preventing usize underflow when called at depth 0.
Changes:
- Guarded
IOReader::decrement_depthso it no-ops whendepth == 0(matchingSliceReader). - Added unit tests validating decrement behavior at depth 0 and depth 1 for both readers (with
IOReadertests gated behindfeature = "std").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the inconsistent behaviors.