Upgrade to charmbracelet/log v2 to fix 10s delay under lefthook/pre-commit hooks

[mAbduqayum]

Related to #524, but a different trigger.

#524 fixed the case where TERM=dumb caused a 10s hang. My TERM is normal (xterm-ghostty), but I still hit a 10s hang when treefmt runs from a git hook via lefthook.

What happens

Direct call: 23 ms. Same files via lefthook: 10 s. The 10s is reported by treefmt itself before any formatter runs.

$ time treefmt some.nix
formatted 0 files (0 changed) in 12ms        → 0.023s

$ time lefthook run pre-commit
formatted 0 files (0 changed) in 10.024s     → 10.044s

Why

Treefmt sends terminal color queries (OSC 10 / 11) on startup. Lefthook gives the child process a pty, so isTTY() returns true and the queries get sent — but there's no real terminal on the other end, so nothing answers. Treefmt waits the full OSC timeout (~10s).

#524's fix only short-circuits when TERM=dumb. With a normal TERM, we still run the probe and still hit the timeout.

Repro

lefthook.yml:

pre-commit:
  commands:
    format:
      glob: '*.nix'
      run: treefmt {staged_files}

treefmt.toml:

[formatter.nix]
command = 'nixfmt'
includes = ['*.nix']

Stage a .nix file, run lefthook run pre-commit.

Workarounds

• TERM=dumb in the hook env → 20 ms. Works.
• CI=1 → also works, but changes behaviour in other tools.
• NO_COLOR=1 → does not help. The probe still runs.

Versions

• treefmt v2.5.0
• lefthook v2.1.5
• NixOS, Linux 6.18

[jfly]

Thanks for the report, @mAbduqayum.

I haven't had time to poke at your repro yet. I did some poking around, trying to understand if treefmt is really the place where one of these workarounds should land.

Have you seen muesli/termenv#136 (comment)? It looks like termenv 0.11 reduced the timeout to 5 seconds. Why are we seeing a full 10s? Is termenv even the relevant code here? It would be helpful if you could share a stack trace (it is treefmt -> charmbracelet/log -> charmbracelet/lipgloss -> termenv?).

Would things get better if we adopted charmbracelet/colorprofile? Sounds like it supports NO_COLOR. It's not clear to me how to use it with charmbracelet/log, though.

[mAbduqayum]

Thanks @jfly.

It looks like termenv 0.11 reduced the timeout to 5 seconds. Why are we seeing a full 10s?

The 10s is in charmbracelet/log v0.4.2 (which treefmt pins), logger.go:287: WithColorCache(true) probes fg+bg colors via OSC queries, each blocking 5s on termenv's OSCTimeout when nothing answers.

log v2 (charm.land/log/v2) switched to colorprofile and sends no OSC queries — verified a minimal repro hangs 10s on v0.4.2 and 0s on v2. So it's fixed once treefmt moves to log v2.

Closing — TERM=dumb in the hook env works meanwhile.

[jfly]

@mAbduqayum, I'm going to reopen this as a reminder to upgrade to log v2.