FIX: Enable GIL for bytes/unicode array casting to/from Quaddtype #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
reviewed
Dec 5, 2025
SwayamInSync
commented
Dec 5, 2025
| loop_descrs[1] = given_descrs[1]; | ||
| // Handle non-native byte order by requesting native byte order | ||
| // NumPy will handle the byte swapping automatically | ||
| if (!PyArray_ISNBO(given_descrs[1]->byteorder)) { |
Member
Author
There was a problem hiding this comment.
I forgot to handle the endianess for quad_to_unicode in prev PR #225 so this is similar to that
ngoldbaum
approved these changes
Dec 5, 2025
Member
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Thanks for working on this and fixing all these issues!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #237
This PR adds the test to replicate issue and flag addition as the fix