From 0240d88be17f1090afa3f21416f26a7afa68a39a Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 27 Dec 2025 20:18:06 +0000
Subject: [PATCH 1/3] Initial plan


From 88f9bb283d80790582e46953dacdea335140f8c4 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 27 Dec 2025 20:21:01 +0000
Subject: [PATCH 2/3] Fix cache invalidation and window validation issues

Co-authored-by: numEricL <13125969+numEricL@users.noreply.github.com>
---
 lua/winbender/highlight.lua | 56 +++++++++++++++++++++++++++++++++----
 1 file changed, 50 insertions(+), 6 deletions(-)

diff --git a/lua/winbender/highlight.lua b/lua/winbender/highlight.lua
index f0582bb..b403554 100644
--- a/lua/winbender/highlight.lua
+++ b/lua/winbender/highlight.lua
@@ -166,16 +166,24 @@ local function get_stored_winhighlight(winid)
 end
 
 local function get_adjusted_winhighlight(winid)
-    if adjusted_winhighlights[winid] then
-        return adjusted_winhighlights[winid]
+    -- Check if we have a valid cached value
+    local current_src = vim.wo[winid].winhighlight or ""
+    local cached = adjusted_winhighlights[winid]
+    if cached and cached.src == current_src then
+        return cached.adjusted
     end
 
+    -- Compute and cache the adjusted highlight
     local hl_groups = get_local_highlight_groups(winid)
     for hl_from, hl_to in pairs(hl_groups) do
         hl_groups[hl_from] = register_adjusted_hl_group(hl_to)
     end
-    adjusted_winhighlights[winid] = concat_winhighlight_dict(hl_groups)
-    return adjusted_winhighlights[winid]
+    local adjusted = concat_winhighlight_dict(hl_groups)
+    adjusted_winhighlights[winid] = {
+        src = current_src,
+        adjusted = adjusted,
+    }
+    return adjusted
 end
 
 local function update_window_highlight(winid)
@@ -209,9 +217,13 @@ function M.enable()
     vim.api.nvim_create_autocmd({ "WinEnter" }, {
         group = augroup,
         callback = function()
-            local old_winid = vim.fn.win_getid(vim.fn.winnr("#"))
             local new_winid = vim.api.nvim_get_current_win()
-            update_window_highlight(old_winid)
+            local old_winid = vim.fn.win_getid(vim.fn.winnr("#"))
+            
+            -- Only update old window if it's valid and different from new window
+            if old_winid ~= 0 and old_winid ~= new_winid and vim.api.nvim_win_is_valid(old_winid) then
+                update_window_highlight(old_winid)
+            end
             update_window_highlight(new_winid)
         end,
         desc = "WinBender: Update window highlights on focus change"
@@ -225,6 +237,38 @@ function M.enable()
         end,
         desc = "WinBender: Don't highlight new windows"
     })
+    
+    -- Clear cache entry when a window is closed to prevent memory leaks
+    vim.api.nvim_create_autocmd("WinClosed", {
+        group = augroup,
+        callback = function(args)
+            local winid = tonumber(args.match)
+            if winid then
+                winhighlights[winid] = nil
+                adjusted_winhighlights[winid] = nil
+            end
+        end,
+        desc = "WinBender: Clear cache for closed windows"
+    })
+    
+    -- Clear all caches when colorscheme changes as highlight definitions may change
+    vim.api.nvim_create_autocmd("ColorScheme", {
+        group = augroup,
+        callback = function()
+            adjusted_winhighlights = {}
+        end,
+        desc = "WinBender: Clear adjusted highlight cache on colorscheme change"
+    })
+    
+    -- Clear adjusted cache when winhighlight option changes
+    vim.api.nvim_create_autocmd("OptionSet", {
+        group = augroup,
+        pattern = "winhighlight",
+        callback = function()
+            adjusted_winhighlights = {}
+        end,
+        desc = "WinBender: Clear adjusted highlight cache on winhighlight change"
+    })
 end
 
 function M.disable()

From 858e9728440980089df1144d555036033cf667de Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 27 Dec 2025 20:21:56 +0000
Subject: [PATCH 3/3] Minor: reorder variable declarations for logical flow

Co-authored-by: numEricL <13125969+numEricL@users.noreply.github.com>
---
 lua/winbender/highlight.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lua/winbender/highlight.lua b/lua/winbender/highlight.lua
index b403554..96f606b 100644
--- a/lua/winbender/highlight.lua
+++ b/lua/winbender/highlight.lua
@@ -217,8 +217,8 @@ function M.enable()
     vim.api.nvim_create_autocmd({ "WinEnter" }, {
         group = augroup,
         callback = function()
-            local new_winid = vim.api.nvim_get_current_win()
             local old_winid = vim.fn.win_getid(vim.fn.winnr("#"))
+            local new_winid = vim.api.nvim_get_current_win()
             
             -- Only update old window if it's valid and different from new window
             if old_winid ~= 0 and old_winid ~= new_winid and vim.api.nvim_win_is_valid(old_winid) then