Skip to content

Commit 1a7ab74

Browse files
authored
Merge pull request #58 from nodes-ios/fix/reset_last_updated
fix: When clearing persisted localizations, set lastUpdatedDate to .distantPast
2 parents 3cac667 + e0377f9 commit 1a7ab74

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

LocalizationManager/Classes/Manager/LocalizationManager.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,8 @@ public class LocalizationManager<Language, Descriptor: LocalizationDescriptor> w
381381
self.handleLocalizationModels(
382382
descriptors: configs,
383383
acceptHeaderUsed: languageAcceptHeader,
384-
completion: completion)
384+
completion: completion
385+
)
385386

386387
case .failure(let error):
387388
//error fetching configs
@@ -615,6 +616,7 @@ public class LocalizationManager<Language, Descriptor: LocalizationDescriptor> w
615616
localizableObjectDictonary.removeAll()
616617

617618
if includingPersisted {
619+
lastUpdatedDate = .distantPast
618620
try deletePersistedLocalizations()
619621
}
620622
}

LocalizationManagerTests/Tests/LocalizationManagerTests.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ class LocalizationManagerTests: XCTestCase {
272272
try manager.clearLocalizations(includingPersisted: true)
273273
let newFilePaths = try FileManager.default.contentsOfDirectory(at: dir, includingPropertiesForKeys: nil, options: [])
274274
XCTAssertTrue(newFilePaths.isEmpty)
275+
XCTAssertEqual(manager.lastUpdatedDate, Date.distantPast)
275276
} catch {
276277
XCTFail("Failed to get contents of directories")
277278
}

Package.swift

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,17 @@ let package = Package(
1111
.target(
1212
name: "LocalizationManager",
1313
path: "LocalizationManager/Classes"
14+
),
15+
.testTarget(
16+
name: "LocalizationManagerTests",
17+
dependencies: [.target(name: "LocalizationManager")],
18+
path: "LocalizationManagerTests"
19+
// exclude: <#T##[String]#>,
20+
// sources: <#T##[String]?#>,
21+
// cSettings: <#T##[CSetting]?#>,
22+
// cxxSettings: <#T##[CXXSetting]?#>,
23+
// swiftSettings: <#T##[SwiftSetting]?#>,
24+
// linkerSettings: <#T##[LinkerSetting]?#>
1425
)
1526
]
1627
)

0 commit comments

Comments
 (0)