From ec7873bbfc339548f272204f3e6090de58c3be21 Mon Sep 17 00:00:00 2001 From: MatteoGabriele Date: Sun, 8 Feb 2026 17:22:39 +0100 Subject: [PATCH 01/11] feat(ui): use icon-only when connected to services --- app/components/Header/AccountMenu.client.vue | 38 ++------------------ 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index 9d9bd3204..94d574bf7 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -65,48 +65,16 @@ function openAuthModal() { class="border-none" > -
- - - - - - - +
+
- - - + {{ $t('account_menu.connect') }} From ecefee3e7ea0c18d79faba0c65a80b1774b17f71 Mon Sep 17 00:00:00 2001 From: MatteoGabriele Date: Sun, 8 Feb 2026 17:30:00 +0100 Subject: [PATCH 02/11] refactor: use top-0 --- app/components/Header/AccountMenu.client.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index 94d574bf7..b3b8caeae 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -70,7 +70,7 @@ function openAuthModal() { class="w-6 h-6 rounded-full bg-bg-muted ring-2 ring-bg flex items-center justify-center" :class="hasBothConnections ? 'relative z-10' : ''" > - +
From 8a2342499941864e205eceb054500c259d7b13e1 Mon Sep 17 00:00:00 2001 From: MatteoGabriele Date: Sun, 8 Feb 2026 17:38:11 +0100 Subject: [PATCH 03/11] feat: add connected text a11y --- app/components/Header/AccountMenu.client.vue | 5 +++-- i18n/locales/en.json | 1 + i18n/locales/it-IT.json | 1 + lunaria/files/en-GB.json | 1 + lunaria/files/en-US.json | 1 + lunaria/files/it-IT.json | 1 + 6 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index b3b8caeae..1dd1d0738 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -68,11 +68,12 @@ function openAuthModal() {
{{ $t('account_menu.connect') }} diff --git a/i18n/locales/en.json b/i18n/locales/en.json index 6fd6a7947..780a7fdc6 100644 --- a/i18n/locales/en.json +++ b/i18n/locales/en.json @@ -790,6 +790,7 @@ }, "account_menu": { "connect": "connect", + "connected": "Connected", "account": "Account", "npm_cli": "npm CLI", "atmosphere": "Atmosphere", diff --git a/i18n/locales/it-IT.json b/i18n/locales/it-IT.json index 57c5f83e7..1b58266a1 100644 --- a/i18n/locales/it-IT.json +++ b/i18n/locales/it-IT.json @@ -768,6 +768,7 @@ }, "account_menu": { "connect": "connetti", + "connected": "connesso", "account": "Account", "npm_cli": "npm CLI", "atmosphere": "Atmosphere", diff --git a/lunaria/files/en-GB.json b/lunaria/files/en-GB.json index 22d33f0a5..8f93dde52 100644 --- a/lunaria/files/en-GB.json +++ b/lunaria/files/en-GB.json @@ -790,6 +790,7 @@ }, "account_menu": { "connect": "connect", + "connected": "Connected", "account": "Account", "npm_cli": "npm CLI", "atmosphere": "Atmosphere", diff --git a/lunaria/files/en-US.json b/lunaria/files/en-US.json index 6fd6a7947..780a7fdc6 100644 --- a/lunaria/files/en-US.json +++ b/lunaria/files/en-US.json @@ -790,6 +790,7 @@ }, "account_menu": { "connect": "connect", + "connected": "Connected", "account": "Account", "npm_cli": "npm CLI", "atmosphere": "Atmosphere", diff --git a/lunaria/files/it-IT.json b/lunaria/files/it-IT.json index 57c5f83e7..1b58266a1 100644 --- a/lunaria/files/it-IT.json +++ b/lunaria/files/it-IT.json @@ -768,6 +768,7 @@ }, "account_menu": { "connect": "connetti", + "connected": "connesso", "account": "Account", "npm_cli": "npm CLI", "atmosphere": "Atmosphere", From 86a9319eca2f9b4a1630a443391ae3e909e0ebcc Mon Sep 17 00:00:00 2001 From: MatteoGabriele Date: Sun, 8 Feb 2026 17:40:42 +0100 Subject: [PATCH 04/11] fix: remove unused computed --- app/components/Header/AccountMenu.client.vue | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index 1dd1d0738..72e98173a 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -18,9 +18,6 @@ const isOpen = shallowRef(false) /** Check if connected to at least one service */ const hasAnyConnection = computed(() => isNpmConnected.value || !!atprotoUser.value) -/** Check if connected to both services */ -const hasBothConnections = computed(() => isNpmConnected.value && !!atprotoUser.value) - /** Only show count of active (pending/approved/running) operations */ const operationCount = computed(() => activeOperations.value.length) From daddc9ee3cf82bd3c2b83fc04863987b792c0681 Mon Sep 17 00:00:00 2001 From: MatteoGabriele Date: Sun, 8 Feb 2026 18:46:58 +0100 Subject: [PATCH 05/11] refactor: use service icon --- app/components/Header/AccountMenu.client.vue | 63 +++++++++----------- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/app/components/Header/AccountMenu.client.vue b/app/components/Header/AccountMenu.client.vue index 72e98173a..f643dcc89 100644 --- a/app/components/Header/AccountMenu.client.vue +++ b/app/components/Header/AccountMenu.client.vue @@ -18,6 +18,9 @@ const isOpen = shallowRef(false) /** Check if connected to at least one service */ const hasAnyConnection = computed(() => isNpmConnected.value || !!atprotoUser.value) +/** Check if connected to both services */ +const hasBothConnections = computed(() => isNpmConnected.value && !!atprotoUser.value) + /** Only show count of active (pending/approved/running) operations */ const operationCount = computed(() => activeOperations.value.length) @@ -62,17 +65,31 @@ function openAuthModal() { class="border-none" > -
+
+ + + + +
- + + + {{ $t('account_menu.connect') }} @@ -115,19 +132,8 @@ function openAuthModal() { class="w-full px-3 py-2.5 flex items-center gap-3 hover:bg-bg-muted transition-colors text-start rounded-md" @click="openConnectorModal" > - - -