Retrieving `getZapMethods` twice returns empty map (ndk 3.0-beta)

[digitalbase]

I've been working on a nasty bug where the zapper is unable to get lud16 or lud06 information the 2nd time.

A script to reproduce the problem

#!/usr/bin/env tsx

import { NDK } from "./ndk";

debug.enable("*");

import debug from "debug";
import { NDKUser } from "./user";
import { NDKZapper } from "./zapper";

const hexpubkey = "8aa70f4433129dadb71330ac89f62b534caa200a9f3ee349a0f4a5593073d1a6";

async function run() {
    const ndk = new NDK({
        // debug: new Debug("*"),
        explicitRelayUrls: ["wss://relay.damus.io", "wss://nos.lol"],
    });

    await ndk.connect();

    const target = new NDKUser({ hexpubkey });

    const zapper = new NDKZapper(target, 100, "msat", {
        comment: "test",
        ndk,
    });

    const zapMethodMap = await zapper.getZapMethods(ndk, hexpubkey);

    console.log(zapMethodMap);

    const zapMethodMap2 = await zapper.getZapMethods(ndk, hexpubkey);

    console.log(zapMethodMap2);
}

run().catch(console.error);

First time the zapMethodMap has what is expected (including lud16 info), 2nd time it's empty. To debug this further i've added a PR that adds some debugging capabilities to fetchUser etc #362

[digitalbase]

To assist with this I cleaned up user tests (#365) and created a case that proves this bug:

it("duplicate fetching of profile", async () => {
            const event = EventGenerator.createEvent(
                0,
                JSON.stringify({
                    name: "Jeff",
                    picture: "https://image.url",
                }),
                pubkey,
            );
            event.created_at = NOW_SEC - 7200;

            ndk.fetchEvent = vi.fn().mockResolvedValueOnce(event);

            const profile = await user.fetchProfile();
            expect(profile?.name).toEqual("Jeff");
            expect(profile?.picture).toEqual("https://image.url");

            const profile2 = await user.fetchProfile();
            expect(profile2?.name).toEqual("Jeff");
            expect(profile2?.picture).toEqual("https://image.url");
        });

I tried to go deeper but this is touching subscription/event/caching internals and i feel lost :(

[digitalbase]

Tried with latest beta.70 because i was hoping 8b9a37c would have addressed the issue. Same problem

 DEV  v3.2.4 /Users/gijs/Projects/ndk/core

 ✓ src/user/nip05.test.ts (1 test) 2ms
 ✓ src/user/follows.test.ts (2 tests) 15ms
 ❯ src/user/index.test.ts (14 tests | 1 failed | 1 skipped) 27ms
   ✓ NDKUser > constructor > sets npub from provided npub 15ms
   ✓ NDKUser > constructor > sets npub from provided hexpubkey 1ms
   ✓ NDKUser > constructor > sets relayUrls from provided relayUrls 1ms
   ✓ NDKUser > constructor > sets pubkey and relayUrls from provided nprofile 1ms
   ✓ NDKUser > pubkey > returns the decoded pubkey 1ms
   ✓ NDKUser > fetchProfile > profile returns metadata event 1ms
   × NDKUser > fetchProfile > duplicate fetching of profile 3ms
     → expected undefined to deeply equal 'Jeff'
   ✓ NDKUser > fetchProfile > newer profile overwrites older profile (two fetches) 1ms
   ↓ NDKUser > fetchProfile > older profile does not overwrite newer profile (two fetches)
   ✓ NDKUser > fetchProfile > Returns updated fields 1ms
   ✓ NDKUser > fetchProfile > Display name is set properly 1ms
   ✓ NDKUser > fetchProfile > Image is set properly 1ms
   ✓ NDKUser > fetchProfile > Allows for arbitrary values to be set on user profiles 1ms
   ✓ NDKUser > validateNip05 > validates the NIP-05 for users 1ms

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/user/index.test.ts > NDKUser > fetchProfile > duplicate fetching of profile
AssertionError: expected undefined to deeply equal 'Jeff'

- Expected: 
"Jeff"

+ Received: 
undefined

 ❯ src/user/index.test.ts:134:36
    132| 
    133|             const profile2 = await user.fetchProfile();
    134|             expect(profile2?.name).toEqual("Jeff");
       |                                    ^
    135|             expect(profile2?.picture).toEqual("https://image.url");
    136|         });

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯


 Test Files  1 failed | 2 passed (3)
      Tests  1 failed | 15 passed | 1 skipped (17)
   Start at  16:10:06
   Duration  593ms (transform 256ms, setup 37ms, collect 1.16s, tests 43ms, environment 0ms, prepare 120ms)

 FAIL  Tests failed. Watching for file changes...
       press h to show help, press q to quit