From 9c8de75b334a6d976336224ea5a9934dcffccfab Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Sat, 28 Feb 2026 14:38:16 -0500 Subject: [PATCH] chore(remark-lint): better invalid type regex --- packages/remark-lint/package.json | 2 +- .../src/rules/__tests__/invalid-type-reference.test.mjs | 5 +++++ packages/remark-lint/src/rules/invalid-type-reference.mjs | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/remark-lint/package.json b/packages/remark-lint/package.json index 81ff915e2b4c5..f8b3c2ae1b14b 100644 --- a/packages/remark-lint/package.json +++ b/packages/remark-lint/package.json @@ -1,7 +1,7 @@ { "name": "@node-core/remark-lint", "type": "module", - "version": "1.2.0", + "version": "1.2.1", "exports": { ".": "./src/index.mjs", "./api": "./src/api.mjs" diff --git a/packages/remark-lint/src/rules/__tests__/invalid-type-reference.test.mjs b/packages/remark-lint/src/rules/__tests__/invalid-type-reference.test.mjs index 714c31f14222b..177e45942e487 100644 --- a/packages/remark-lint/src/rules/__tests__/invalid-type-reference.test.mjs +++ b/packages/remark-lint/src/rules/__tests__/invalid-type-reference.test.mjs @@ -26,6 +26,11 @@ const testCases = [ 'Type reference should be separated by "|", without spaces; saw "{string | boolean}"', ], }, + { + name: 'newline, multiple references', + input: 'Psst, are you a {string|\nboolean}', + expected: [], + }, { name: 'invalid references', input: 'This is {invalid}.', diff --git a/packages/remark-lint/src/rules/invalid-type-reference.mjs b/packages/remark-lint/src/rules/invalid-type-reference.mjs index a4dc36666f75a..80d2fba986a93 100644 --- a/packages/remark-lint/src/rules/invalid-type-reference.mjs +++ b/packages/remark-lint/src/rules/invalid-type-reference.mjs @@ -3,8 +3,8 @@ import createQueries from '@nodejs/doc-kit/src/utils/queries/index.mjs'; import { lintRule } from 'unified-lint-rule'; import { visit } from 'unist-util-visit'; -const MATCH_RE = /\s\||\|\s/g; -const REPLACE_RE = /\s*\|\s*/g; +const MATCH_RE = /\s\||\| /g; +const REPLACE_RE = /\s*\| */g; /** * Ensures that all type references are valid