add codecov tests, use assert/strict

Author: avivkeller

.github/workflows/lint-and-tests.yml

@@ -132,8 +132,14 @@ jobs:
         # that changes to dependencies or translations don't break the Unit Tests
         run: npm run test:ci
 
-      - name: Upload
-        if: success() || failure()
+      - name: Upload test coverage to Codecov
+        if: ${{ !cancelled() }}
         uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5.4.0
         with:
           files: ./apps/site/lcov.info,./packages/ui-components/lcov.info
+
+      - name: Upload test results to Codecov
+        if: ${{ !cancelled() }}
+        uses: codecov/test-results-action@f2dba722c67b86c6caa034178c6e4d35335f6706 # v1.1.0
+        with:
+          files: ./apps/site/junit.xml,./packages/ui-components/junit.xml

apps/site/components/Blog/BlogHeader/__tests__/index.test.jsx

@@ -1,5 +1,5 @@
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 
 import { render, screen } from '@testing-library/react';
 
@@ -9,24 +9,24 @@ describe('BlogHeader', () => {
   it('should have correct href when category is all', () => {
     render(<BlogHeader category="all" />);
     const link = screen.getByRole('link');
-    assert.strictEqual(link.getAttribute('href'), '/feed/blog.xml');
+    assert.equal(link.getAttribute('href'), '/feed/blog.xml');
   });
 
   it('should have correct href when category is release', () => {
     render(<BlogHeader category="release" />);
     const link = screen.getByRole('link');
-    assert.strictEqual(link.getAttribute('href'), '/feed/releases.xml');
+    assert.equal(link.getAttribute('href'), '/feed/releases.xml');
   });
 
   it('should have correct href when category is vulnerability', () => {
     render(<BlogHeader category="vulnerability" />);
     const link = screen.getByRole('link');
-    assert.strictEqual(link.getAttribute('href'), '/feed/vulnerability.xml');
+    assert.equal(link.getAttribute('href'), '/feed/vulnerability.xml');
   });
 
   it('should have correct href when category is random', () => {
     render(<BlogHeader category="random" />);
     const link = screen.getByRole('link');
-    assert.strictEqual(link.getAttribute('href'), '/feed/blog.xml');
+    assert.equal(link.getAttribute('href'), '/feed/blog.xml');
   });
 });

apps/site/components/Blog/BlogPostCard/__tests__/index.test.jsx

@@ -1,6 +1,6 @@
 import { render, screen } from '@testing-library/react';
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { isVisible } from '../../../../../../tests/utilities.mjs';
 
 import BlogPostCard from '@/components/Blog/BlogPostCard';
@@ -38,11 +38,11 @@ describe('BlogPostCard', () => {
     it('Renders the title prop correctly', () => {
       const { title } = renderBlogPostCard({});
 
-      assert.strictEqual(screen.getAllByText(title).length, 2);
+      assert.equal(screen.getAllByText(title).length, 2);
 
       // title from preview should be ignored as the one from Links
       // and blog card/post are what matter
-      assert.strictEqual(
+      assert.equal(
         screen.getAllByText(title)[0].getAttribute('aria-hidden'),
         'true'
       );

apps/site/hooks/react-client/__tests__/useClientContext.test.jsx

@@ -4,7 +4,7 @@ import useClientContext from '@/hooks/react-client/useClientContext';
 import { MatterContext } from '@/providers/matterProvider';
 
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 
 describe('useClientContext', () => {
   it('should return client context values', () => {

apps/site/hooks/react-client/__tests__/useCopyToClipboard.test.jsx

@@ -1,6 +1,6 @@
 import { render, fireEvent, screen } from '@testing-library/react';
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { setTimeout } from 'node:timers/promises';
 
 import useCopyToClipboard from '@/hooks/react-client/useCopyToClipboard';
@@ -34,10 +34,9 @@ await describe('useCopyToClipboard', async () => {
 
     assert.ok((await screen.findByText(/copy/i)).ownerDocument);
 
-    assert(navigator.clipboard.writeText.mock.callCount(), 1);
-    assert.deepStrictEqual(
-      navigator.clipboard.writeText.mock.calls[0].arguments,
-      ['test']
-    );
+    assert.ok(navigator.clipboard.writeText.mock.callCount(), 1);
+    assert.deepEqual(navigator.clipboard.writeText.mock.calls[0].arguments, [
+      'test',
+    ]);
   });
 });

apps/site/hooks/react-client/__tests__/useDetectOS.test.mjs

@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, afterEach } from 'node:test';
 
 import { renderHook, waitFor } from '@testing-library/react';
@@ -35,7 +35,7 @@ describe('useDetectOS', () => {
     const { result } = renderHook(() => useDetectOS());
 
     await waitFor(() => {
-      assert.deepStrictEqual(result.current, {
+      assert.deepEqual(result.current, {
         os: 'WIN',
         bitness: '64',
         architecture: 'x86',
@@ -52,7 +52,7 @@ describe('useDetectOS', () => {
     const { result } = renderHook(() => useDetectOS());
 
     await waitFor(() => {
-      assert.deepStrictEqual(result.current, {
+      assert.deepEqual(result.current, {
         os: 'WIN',
         bitness: '64',
         architecture: 'x86',
@@ -69,7 +69,7 @@ describe('useDetectOS', () => {
     const { result } = renderHook(() => useDetectOS());
 
     await waitFor(() => {
-      assert.deepStrictEqual(result.current, {
+      assert.deepEqual(result.current, {
         os: 'MAC',
         bitness: '32',
         architecture: 'x86',

apps/site/hooks/react-client/__tests__/useMediaQuery.test.mjs

@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 
 import { renderHook } from '@testing-library/react';
@@ -10,7 +10,7 @@ const noop = () => {};
 describe('useMediaQuery', () => {
   it('should return undefined initially', () => {
     const { result } = renderHook(() => useMediaQuery('media-query-mock'));
-    assert.strictEqual(result.current, false);
+    assert.equal(result.current, false);
   });
 
   it('should return true for matched query', () => {
@@ -25,7 +25,7 @@ describe('useMediaQuery', () => {
     });
 
     const { result } = renderHook(() => useMediaQuery('media-query-mock'));
-    assert.strictEqual(result.current, true);
+    assert.equal(result.current, true);
   });
 
   it('should return false for not-matched query', () => {
@@ -40,7 +40,7 @@ describe('useMediaQuery', () => {
     });
 
     const { result } = renderHook(() => useMediaQuery('media-query-mock'));
-    assert.strictEqual(result.current, false);
+    assert.equal(result.current, false);
   });
 
   it('should subscribe for media changes', t => {
@@ -59,6 +59,6 @@ describe('useMediaQuery', () => {
     });
 
     renderHook(() => useMediaQuery('media-query-mock'));
-    assert.strictEqual(listenerMock.mock.callCount(), 1);
+    assert.equal(listenerMock.mock.callCount(), 1);
   });
 });

apps/site/hooks/react-client/__tests__/useNotification.test.jsx

@@ -3,7 +3,7 @@ import { render } from '@testing-library/react';
 import useNotification from '@/hooks/react-client/useNotification';
 import { NotificationProvider } from '@/providers/notificationProvider';
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 
 describe('useNotification', () => {
   it('should return the notification dispatch function', () => {
@@ -48,6 +48,6 @@ describe('useNotification', () => {
       return element.textContent === 'Dispatch unavailable';
     });
 
-    assert.strictEqual(result, null);
+    assert.equal(result, null);
   });
 });

apps/site/next-data/generators/__tests__/releaseData.test.mjs

@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 
 describe('generateReleaseData', () => {
@@ -37,7 +37,7 @@ describe('generateReleaseData', () => {
 
     const result = await generateReleaseData();
 
-    assert.strictEqual(result.length, 1);
+    assert.equal(result.length, 1);
     assert.partialDeepStrictEqual(result[0], {
       major: 14,
       version: '14.0.0',

apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs

@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 
 import generateWebsiteFeeds from '@/next-data/generators/websiteFeeds.mjs';
@@ -23,18 +23,18 @@ describe('generateWebsiteFeeds', () => {
     };
 
     const result = generateWebsiteFeeds(blogData);
-    assert.strictEqual(result.size, 3);
+    assert.equal(result.size, 3);
 
     const blogFeed = result.get('blog.xml');
-    assert.deepStrictEqual(blogFeed.options, {
+    assert.deepEqual(blogFeed.options, {
       id: siteConfig.rssFeeds[0].file,
       title: siteConfig.rssFeeds[0].title,
       language: 'en',
       link: `${base}/feed/${siteConfig.rssFeeds[0].file}`,
       description: siteConfig.rssFeeds[0].description,
     });
 
-    assert.deepStrictEqual(blogFeed.items, [
+    assert.deepEqual(blogFeed.items, [
       {
         author: blogData.posts[0].author,
         id: blogData.posts[0].slug,