1744662623000

Author: avivkeller

apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs

@@ -26,7 +26,7 @@ describe('generateWebsiteFeeds', () => {
           slug: '/post-1',
           title: 'Post 1',
           author: 'Author 1',
-          date: '2024-02-18',
+          date: '2025-04-18',
           categories: ['all'],
         },
       ],
@@ -36,6 +36,7 @@ describe('generateWebsiteFeeds', () => {
     expect(result.size).toBe(3);
 
     const blogFeed = result.get('blog.xml');
+    const expectedDate = new Date('2025-04-18');
 
     expect(blogFeed.options.id).toBe('blog.xml');
     expect(blogFeed.options.title).toBe('Node.js Blog');
@@ -45,9 +46,10 @@ describe('generateWebsiteFeeds', () => {
     expect(blogFeed.items.length).toBe(1);
     const feedItem = blogFeed.items[0];
     expect(feedItem.id).toBe('/post-1');
+    expect(feedItem.guid).toBe(`/post-1?${expectedDate.getTime()}`);
     expect(feedItem.title).toBe('Post 1');
     expect(feedItem.author).toBe('Author 1');
-    expect(feedItem.date).toEqual(new Date('2024-02-18'));
+    expect(feedItem.date).toEqual(expectedDate);
     expect(feedItem.link).toBe('https://nodejs.org/en/post-1');
   });
 });

apps/site/next-data/generators/websiteFeeds.mjs

@@ -9,6 +9,11 @@ import { siteConfig } from '../../next.json.mjs';
 // with English locale (which is where the website feeds run)
 const canonicalUrl = `${BASE_URL}${BASE_PATH}/en`;
 
+// This is April 16th, 2025, which is around the time that https://github.com/nodejs/nodejs.org/pull/7648
+// was merged. This ensures that future article edits are properly timestamped, while also preventing the
+// currently-published article GUIDs from changing
+const guidTimestampStartDate = 1744662623000;
+
 /**
  * This method generates RSS website feeds based on the current website configuration
  * and the current blog data that is available
@@ -35,13 +40,18 @@ const generateWebsiteFeeds = ({ posts }) => {
         .filter(post => post.categories.includes(category))
         .map(post => {
           const date = new Date(post.date);
+          const time = date.getTime();
+
           return {
             id: post.slug,
             title: post.title,
             author: post.author,
             date,
             link: `${canonicalUrl}${post.slug}`,
-            guid: `${post.slug}?${date.getTime()}`,
+            guid:
+              time > guidTimestampStartDate
+                ? `${post.slug}?${date.getTime()}`
+                : post.slug,
           };
         });