Skip to content

Commit 41eab27

Browse files
committed
chore(git-node): remove abort error in case of fixable error
1 parent 07d5ba0 commit 41eab27

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

lib/promote_release.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -523,11 +523,7 @@ export default class ReleasePromotion extends Session {
523523
cli.separator();
524524
cli.info('Resolve the conflicts and commit the result');
525525
cli.separator();
526-
const didResolveConflicts = await cli.prompt(
527-
'Finished resolving cherry-pick conflicts?', { defaultAnswer: true });
528-
if (!didResolveConflicts) {
529-
throw new Error('Aborted');
530-
}
526+
await cli.prompt('Ready to continue?', { defaultAnswer: true });
531527
}
532528

533529
if (existsSync('.git/CHERRY_PICK_HEAD')) {
@@ -537,16 +533,20 @@ export default class ReleasePromotion extends Session {
537533
}
538534

539535
// Validate release commit on the default branch
540-
const releaseCommitOnDefaultBranch =
541-
await forceRunAsync('git', ['show', 'HEAD', '--name-only', '--pretty=format:%s'],
542-
{ captureStdout: true, ignoreFailure: false });
543-
const [commitTitle, ...modifiedFiles] = releaseCommitOnDefaultBranch.trim().split('\n');
544-
await this.validateReleaseCommit(commitTitle);
545-
if (modifiedFiles.some(file => !file.endsWith('.md'))) {
546-
cli.warn('Some modified files are not markdown, that\'s unusual.');
547-
cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`);
548-
if (!await cli.prompt('Do you want to proceed anyway?', { defaultAnswer: false })) {
549-
throw new Error('Aborted');
536+
while (true) {
537+
const releaseCommitOnDefaultBranch =
538+
await forceRunAsync('git', ['show', 'HEAD', '--name-only', '--pretty=format:%s'],
539+
{ captureStdout: true, ignoreFailure: false });
540+
const [commitTitle, ...modifiedFiles] = releaseCommitOnDefaultBranch.trim().split('\n');
541+
await this.validateReleaseCommit(commitTitle);
542+
if (modifiedFiles.some(file => !file.endsWith('.md'))) {
543+
cli.warn('Some modified files are not markdown, that\'s unusual.');
544+
cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`);
545+
if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', {
546+
defaultAnswer: false
547+
})) {
548+
break;
549+
}
550550
}
551551
}
552552
}

0 commit comments

Comments
 (0)