From 6409d53e5c70f23b56c5d83f6bf5b60c9101365d Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Thu, 5 Mar 2026 18:48:09 -0500 Subject: [PATCH 1/6] Remove pnpm option from publish workflow Removed the pnpm option from the setup-environment step. --- .github/workflows/publish.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 04dfdc0a..7690533c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -77,7 +77,6 @@ jobs: steps: - uses: nodejs/web-team/actions/setup-environment@9f3c83af227d721768d9dbb63009a47ed4f4282f with: - pnpm: true use-version-file: true registry-url: 'https://registry.npmjs.org' From 13c151552c494f8c9f2c626942dbaff2727a2fbd Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Thu, 5 Mar 2026 18:51:26 -0500 Subject: [PATCH 2/6] fixup! --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 7690533c..fd84e876 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -66,7 +66,7 @@ jobs: run: | OLD_VERSION=$(git show $COMMIT_SHA~1:package.json | jq -r '.version') NEW_VERSION=$(jq -r '.version' "package.json") - if [ "$OLD_VERSION" != "$NEW_VERSION" ]; then + if [ "$OLD_VERSION" != "$NEW_VERSION" ] || [ "$EVENT_NAME" == "workflow_dispatch" ]; then echo "should_publish=true" >> $GITHUB_OUTPUT fi From 3f75799773f665cfe3ae405b68950e2b6b1a6387 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Thu, 5 Mar 2026 18:53:44 -0500 Subject: [PATCH 3/6] fixup! --- .github/workflows/publish.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index fd84e876..1c05aed5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -21,6 +21,7 @@ env: jobs: prepare: runs-on: ubuntu-latest + if: ${{ github.event_name != 'workflow_dispatch' }} outputs: # Output the matrix of packages to publish for use in the publish job should_publish: ${{ steps.check.outputs.should_publish }} @@ -61,19 +62,17 @@ jobs: - name: Check if we should publish id: check - env: - EVENT_NAME: ${{ github.event_name }} run: | OLD_VERSION=$(git show $COMMIT_SHA~1:package.json | jq -r '.version') NEW_VERSION=$(jq -r '.version' "package.json") - if [ "$OLD_VERSION" != "$NEW_VERSION" ] || [ "$EVENT_NAME" == "workflow_dispatch" ]; then + if [ "$OLD_VERSION" != "$NEW_VERSION" ]; then echo "should_publish=true" >> $GITHUB_OUTPUT fi publish: needs: prepare runs-on: ubuntu-latest - if: needs.prepare.outputs.should_publish == 'true' + if: github.event_name == 'workflow_dispatch' || needs.prepare.outputs.should_publish == 'true' steps: - uses: nodejs/web-team/actions/setup-environment@9f3c83af227d721768d9dbb63009a47ed4f4282f with: From 46768b490f99b903b05158b7dca0037b55bb1eca Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Thu, 5 Mar 2026 18:55:19 -0500 Subject: [PATCH 4/6] fixup! --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 1c05aed5..f36d0319 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -72,7 +72,7 @@ jobs: publish: needs: prepare runs-on: ubuntu-latest - if: github.event_name == 'workflow_dispatch' || needs.prepare.outputs.should_publish == 'true' + if: ${{ github.event_name == 'workflow_dispatch' || needs.prepare.outputs.should_publish == 'true' }} steps: - uses: nodejs/web-team/actions/setup-environment@9f3c83af227d721768d9dbb63009a47ed4f4282f with: From d0bb74f78f55e327f26b9cc094adb820bedb2b2e Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Thu, 5 Mar 2026 18:56:01 -0500 Subject: [PATCH 5/6] fixup! --- .github/workflows/publish.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index f36d0319..91ee46f2 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -21,7 +21,6 @@ env: jobs: prepare: runs-on: ubuntu-latest - if: ${{ github.event_name != 'workflow_dispatch' }} outputs: # Output the matrix of packages to publish for use in the publish job should_publish: ${{ steps.check.outputs.should_publish }} From a66cc26a7f46ab48d2c7447f243aad91ee04b026 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Thu, 5 Mar 2026 18:57:22 -0500 Subject: [PATCH 6/6] fixup! --- .github/workflows/publish.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 91ee46f2..b739f9a8 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -33,6 +33,7 @@ jobs: - name: Verify commit authenticity env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + if: ${{ github.event_name != 'workflow_dispatch' }} run: | # Get commit data from GitHub API to verify its authenticity COMMIT_DATA=$(gh api repos/${{ github.repository }}/commits/$COMMIT_SHA) @@ -61,17 +62,19 @@ jobs: - name: Check if we should publish id: check + env: + EVENT_NAME: ${{ github.event_name }} run: | OLD_VERSION=$(git show $COMMIT_SHA~1:package.json | jq -r '.version') NEW_VERSION=$(jq -r '.version' "package.json") - if [ "$OLD_VERSION" != "$NEW_VERSION" ]; then + if [ "$OLD_VERSION" != "$NEW_VERSION" ] || [ "$EVENT_NAME" == "workflow_dispatch" ]; then echo "should_publish=true" >> $GITHUB_OUTPUT fi publish: needs: prepare runs-on: ubuntu-latest - if: ${{ github.event_name == 'workflow_dispatch' || needs.prepare.outputs.should_publish == 'true' }} + if: needs.prepare.outputs.should_publish == 'true' steps: - uses: nodejs/web-team/actions/setup-environment@9f3c83af227d721768d9dbb63009a47ed4f4282f with: