chore: better index path validation of creation

Author: MagicFun1241

store/store.go

@@ -90,29 +90,52 @@ func (s *IndexStore) CreateIndex(config *models.IndexConfig) error {
 
 	indexPath := filepath.Join(s.dataDir, config.ID)
 
-	// Create index mapping
-	indexMapping := bleve.NewIndexMapping()
+	var index bleve.Index
+	var err error
 
-	// Apply exclude attributes if specified
+	// Check if index directory already exists on disk
+	if _, statErr := os.Stat(indexPath); statErr == nil {
+		// Directory exists, try to open existing index
+		index, err = bleve.Open(indexPath)
+		if err != nil {
+			// Failed to open, remove and recreate
+			os.RemoveAll(indexPath)
+			index, err = s.createNewIndex(indexPath, config)
+			if err != nil {
+				return err
+			}
+		}
+	} else {
+		// Directory doesn't exist, create new index
+		index, err = s.createNewIndex(indexPath, config)
+		if err != nil {
+			return err
+		}
+	}
+
+	s.indexes[config.ID] = index
+	s.configs[config.ID] = config
+	s.indexLocks[config.ID] = &sync.RWMutex{}
+	s.saveConfigs()
+
+	return nil
+}
+
+// createNewIndex creates a new bleve index with the given config
+func (s *IndexStore) createNewIndex(indexPath string, config *models.IndexConfig) (bleve.Index, error) {
+	indexMapping := bleve.NewIndexMapping()
 	if len(config.ExcludeAttributes) > 0 {
 		defaultMapping := indexMapping.DefaultMapping
 		for _, attr := range config.ExcludeAttributes {
 			disabledMapping := bleve.NewDocumentDisabledMapping()
 			defaultMapping.AddSubDocumentMapping(attr, disabledMapping)
 		}
 	}
-
 	index, err := bleve.New(indexPath, indexMapping)
 	if err != nil {
-		return fmt.Errorf("failed to create index: %w", err)
+		return nil, fmt.Errorf("failed to create index: %w", err)
 	}
-
-	s.indexes[config.ID] = index
-	s.configs[config.ID] = config
-	s.indexLocks[config.ID] = &sync.RWMutex{}
-	s.saveConfigs()
-
-	return nil
+	return index, nil
 }
 
 // GetIndex returns an index by ID
@@ -305,32 +328,16 @@ func (s *IndexStore) CreateIndexInternal(config *models.IndexConfig) error {
 		if err != nil {
 			// Failed to open, remove and recreate
 			os.RemoveAll(indexPath)
-			indexMapping := bleve.NewIndexMapping()
-			if len(config.ExcludeAttributes) > 0 {
-				defaultMapping := indexMapping.DefaultMapping
-				for _, attr := range config.ExcludeAttributes {
-					disabledMapping := bleve.NewDocumentDisabledMapping()
-					defaultMapping.AddSubDocumentMapping(attr, disabledMapping)
-				}
-			}
-			index, err = bleve.New(indexPath, indexMapping)
+			index, err = s.createNewIndex(indexPath, config)
 			if err != nil {
-				return fmt.Errorf("failed to create index: %w", err)
+				return err
 			}
 		}
 	} else {
 		// Directory doesn't exist, create new index
-		indexMapping := bleve.NewIndexMapping()
-		if len(config.ExcludeAttributes) > 0 {
-			defaultMapping := indexMapping.DefaultMapping
-			for _, attr := range config.ExcludeAttributes {
-				disabledMapping := bleve.NewDocumentDisabledMapping()
-				defaultMapping.AddSubDocumentMapping(attr, disabledMapping)
-			}
-		}
-		index, err = bleve.New(indexPath, indexMapping)
+		index, err = s.createNewIndex(indexPath, config)
 		if err != nil {
-			return fmt.Errorf("failed to create index: %w", err)
+			return err
 		}
 	}