Skip to content

Error message for convert_output is inconsistent with accepted inputs #182

@kellijohnson-NOAA

Description

@kellijohnson-NOAA

"i" = "Accepted `model` options: SS3, BAM, WHAM, AMAK, JABBA."

prints

Image

but the function documentation states that the allowed inputs are all lowercase. Also the documentation does not indicate what happens when the default of NULL is left for the parameter input. I personally do not think that the NULL functionality is very robust because there might be multiple model types in the future that have .rds or RDATA files and this internal functionality will break down. My suggestion would be to list all of the options in the function specification and use a match.arg() call in the first few lines of the function to ensure that the option provided is available.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions