Skip to content

[Bug]: Ctl file Age for L1 and L2 issue with growth option 8 #659

@e-perl-NOAA

Description

@e-perl-NOAA

Describe the bug

From Mark Maunder:

In the control file we have
“999 #_Age(post-settlement) for L2 (aka Amax); 999 to treat as Linf”

Interesting, in the control new we get
“0 #_Age(post-settlement) for L2 (aka Amax); 999 to treat as Linf”

In the ss3-source-code, we have the following:

if (Grow_type == 8 && AFIX2 != 999)
   {
     warnstream << "AFIX2 set to 999 for grow_type==8 because only Linfinity allowed for growth cessation ";
     write_message (ADJUST, 0);
     AFIX2 = 999.;
   }
   if (Grow_type == 8 && AFIX != 0.0)
   {
     warnstream << "AFIX set to 0.0 for grow_type==8;  growth cessation ";
     write_message (ADJUST, 0);
     AFIX2 = 0.0;
   }

Suggested changes:

  1. The second warning should be changed to AFIX = 0.0;
  2. Also suggest changing AFIX to something more intuitive, such as what it is called in the control file Age(post-settlement) for L1 (aka Amin)

To Reproduce

  1. Create a model that uses growth cessation (option 8)
  2. Set Amin as 1

Expected behavior

Get a warning to set Amin as 0

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

3.30.23.1

Additional Context

No response

Metadata

Metadata

Labels

change loguse for issues that should appear in change logwarnings

Type

No type

Projects

Status

Done

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions