Upstreaming modules to nixos-hardware

[Malix-Labs]

Hello again folks!

As you mentioned in your nixos-facter introduction blog:

Provided that certain sensitive information, such as serial numbers and MAC addresses, is filtered out, there is no reason why these hardware reports could not be shared after they are generated for things like EC2 instance types, specific laptop models, and so on, much like NixOS Hardware currently shares Nix configs.

Have you considered depending and upstreaming configurations with https://github.com/NixOS/nixos-hardware directly?

[Frontear]

Better yet, the main bread and butter of this project should be pushed to https://github.com/NixOS/nixpkgs, whilst the modules could go into https://github.com/NixOS/nixos-hardware. I don't know if this is still planned, but it would be great if it was so, especially the former as NixOS really lacks a good way to declare hardware stuff without having to stick it in random options everywhere.

[brianmcgee]

Upstreaming is planned. Don't quote me on it, but work should start happening in the next couple of months.

[Malix-Labs]

#215 (comment) from @Frontear :

the main bread and butter of this project should be pushed to https://github.com/NixOS/nixpkgs

Nixpkgs or a flake works out, yes

The crucial point is to share efforts with the nixos-hardware team to have the best of both world, as I think nixos-facter is the best hardware scanning tool in the NixOS ecosystem, and nixos-hardware has the most comprehensive hardware modules

[Malix-Labs]

#215 (comment) from @brianmcgee :

Upstreaming is planned. Don't quote me on it, but work should start happening in the next couple of months.

That's wonderful Brian!

Do you already know / have a plan for what what https://github.com/nix-community/nixos-facter-modules will become?

[brianmcgee]

@Malix-Labs I have some idea but better to speak with @flokli as he's gonna be handling the upstreaming 🙂

[Mic92]

In progress: NixOS/nixpkgs#458177

[Mic92]

@Malix-Labs @Frontear can you review?

[Frontear]

@Malix-Labs @Frontear can you review?

Yep!