fix: clippy warnings - field_reassign_with_default, too_many_arguments, redundant_closure

Author: nirvagold

src/api/handlers.rs

@@ -838,40 +838,38 @@ async fn handle_solana_token(
     };
 
     // Calculate risk score using ML scorer
-    let mut features = MLFeatureSet::default();
-    
-    // Liquidity features
-    features.liquidity = LiquidityFeatures {
-        total_liquidity_usd: liquidity_usd.unwrap_or(0.0),
-        is_locked: false, // Can't determine for Solana easily
-        lock_duration_days: 0,
-        lp_holder_count: 0,
-        top_lp_holder_percent: 0.0,
-        pool_count: solana_pairs.len() as u32,
-    };
-    
-    // Trading features (estimate from volume)
-    features.trading = TradingFeatures {
-        volume_24h_usd: volume_24h_usd.unwrap_or(0.0),
-        holder_count: 0, // Would need additional RPC call
-        top_10_holder_percent: 0.0,
-        buy_count_24h: 0,
-        sell_count_24h: 0,
-        largest_sell_percent: 0.0,
-        price_change_24h: 0.0,
+    let features = MLFeatureSet {
+        liquidity: LiquidityFeatures {
+            total_liquidity_usd: liquidity_usd.unwrap_or(0.0),
+            is_locked: false,
+            lock_duration_days: 0,
+            lp_holder_count: 0,
+            top_lp_holder_percent: 0.0,
+            pool_count: solana_pairs.len() as u32,
+        },
+        trading: TradingFeatures {
+            volume_24h_usd: volume_24h_usd.unwrap_or(0.0),
+            holder_count: 0,
+            top_10_holder_percent: 0.0,
+            buy_count_24h: 0,
+            sell_count_24h: 0,
+            largest_sell_percent: 0.0,
+            price_change_24h: 0.0,
+        },
+        social: SocialFeatures {
+            age_hours: 1,
+            has_website: false,
+            has_twitter: false,
+            has_telegram: false,
+            twitter_followers: 0,
+            telegram_members: 0,
+            is_verified_project: false,
+        },
+        ..Default::default()
     };
 
-    // Social features - check if pump.fun
+    // Check if pump.fun
     let is_pump_fun = best_pair.dex_id.to_lowercase().contains("pump");
-    features.social = SocialFeatures {
-        age_hours: 1, // Assume new for pump.fun tokens
-        has_website: false,
-        has_twitter: false,
-        has_telegram: false,
-        twitter_followers: 0,
-        telegram_members: 0,
-        is_verified_project: false,
-    };
 
     // Calculate ML risk score
     let ml_scorer = MLRiskScorer::new();

src/providers/alchemy.rs

@@ -293,6 +293,7 @@ impl AlchemyClient {
     /// 
     /// Compute Units: 120 CU
     /// Reference: https://alchemy.com/docs/reference/transfers-api-quickstart.mdx
+    #[allow(clippy::too_many_arguments)]
     pub async fn get_asset_transfers(
         &self,
         from_address: Option<&str>,

src/providers/trace.rs

@@ -678,7 +678,7 @@ mod tests {
     #[test]
     fn test_honeypot_confidence_calculation() {
         // This would be a more complex test in practice
-        let red_flags = vec![
+        let red_flags = [
             HoneypotRedFlag {
                 flag_type: RedFlagType::BlacklistCall,
                 description: "Test".to_string(),

src/providers/websocket.rs

@@ -286,7 +286,7 @@ impl AlchemyWsClient {
                 sub_id,
                 tx,
                 is_connected,
-                |msg| Self::parse_new_head(msg),
+                Self::parse_new_head,
             )
             .await;
         });
@@ -313,7 +313,7 @@ impl AlchemyWsClient {
                 sub_id,
                 tx,
                 is_connected,
-                |msg| Self::parse_log(msg),
+                Self::parse_log,
             )
             .await;
         });
@@ -354,7 +354,7 @@ impl AlchemyWsClient {
                 sub_id,
                 tx,
                 is_connected,
-                |msg| Self::parse_pending_tx(msg),
+                Self::parse_pending_tx,
             )
             .await;
         });
@@ -382,7 +382,7 @@ impl AlchemyWsClient {
                 sub_id,
                 tx,
                 is_connected,
-                |msg| Self::parse_mined_tx(msg),
+                Self::parse_mined_tx,
             )
             .await;
         });
@@ -756,6 +756,6 @@ mod tests {
 
         let weth = "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2";
         let new_token = event.get_new_token(weth);
-        assert_eq!(new_token, Some("0xnewtoken".as_ref()));
+        assert_eq!(new_token, Some("0xnewtoken"));
     }
 }