TEST: Test xor, requires constraints on name_source traits

Author: effigies

nipype/interfaces/base/core.py

@@ -1123,6 +1123,9 @@ def _filename_from_source(self, name, chain=None):
                 base = self._filename_from_source(ns, chain)
                 if isdefined(base):
                     _, _, source_ext = split_filename(base)
+                else:
+                    # Do not generate filename when required fields are missing
+                    return retval
 
             chain = None
             retval = name_template % base

nipype/interfaces/base/tests/test_specs.py

@@ -274,6 +274,55 @@ class TestCycle(nib.CommandLine):
     assert '%s_generated_mootpl' % nme in res
 
 
+def test_namesource_constraints(setup_file):
+    tmp_infile = setup_file
+    tmpd, nme, ext = split_filename(tmp_infile)
+
+    class constrained_spec(nib.CommandLineInputSpec):
+        in_file = nib.File(argstr="%s", position=1)
+        threshold = traits.Float(
+            argstr="%g",
+            xor=['mask_file'],
+            position=2)
+        mask_file = nib.File(
+            argstr="%s",
+            name_source=['in_file'],
+            name_template='%s_mask',
+            keep_extension=True,
+            xor=['threshold'],
+            position=2)
+        out_file1 = nib.File(
+            argstr="%s",
+            name_source=['in_file'],
+            name_template='%s_out1',
+            keep_extension=True,
+            position=3)
+        out_file2 = nib.File(
+            argstr="%s",
+            name_source=['in_file'],
+            name_template='%s_out2',
+            keep_extension=True,
+            requires=['threshold'],
+            position=4)
+
+    class TestConstrained(nib.CommandLine):
+        _cmd = "mycommand"
+        input_spec = constrained_spec
+
+    tc = TestConstrained()
+
+    # name_source undefined, so template traits remain undefined
+    assert tc.cmdline == 'mycommand'
+
+    # mask_file and out_file1 enabled by name_source definition
+    tc.inputs.in_file = os.path.basename(tmp_infile)
+    assert tc.cmdline == 'mycommand foo.txt foo_mask.txt foo_out1.txt'
+
+    # mask_file disabled by threshold, out_file2 enabled by threshold
+    tc.inputs.threshold = 10.
+    assert tc.cmdline == 'mycommand foo.txt 10 foo_out1.txt foo_out2.txt'
+
+
 def test_TraitedSpec_withFile(setup_file):
     tmp_infile = setup_file
     tmpd, nme = os.path.split(tmp_infile)