TST: remove unnecesary checks, document necessary checks

Author: Ben Cipollini

nibabel/gifti/tests/test_gifti.py

@@ -179,7 +179,6 @@ def assign_metadata(val):
 
 
 def test_data_tag_deprecated():
-    GiftiImage()
     with clear_and_catch_warnings() as w:
         warnings.filterwarnings('once', category=DeprecationWarning)
         data_tag(np.array([]), 'ASCII', '%i', 1)

nibabel/nicom/tests/test_csareader.py

@@ -108,7 +108,7 @@ def test_csa_params():
     assert_equal(b_matrix.shape, (3, 3))
     # check (by absence of error) that the B matrix is positive
     # semi-definite.
-    dwp.B2q(b_matrix)
+    dwp.B2q(b_matrix)  # no error
     b_value = csa.get_b_value(csa_info)
     assert_equal(b_value, 1000)
     g_vector = csa.get_g_vector(csa_info)

nibabel/tests/test_data.py

@@ -238,7 +238,7 @@ def test_make_datasource():
 @raises(DataError)
 def test_bomber():
     b = Bomber('bomber example', 'a message')
-    b.any_attribute
+    b.any_attribute  # no error
 
 
 def test_bomber_inspect():

nibabel/tests/test_ecat.py

@@ -172,7 +172,6 @@ def test_subheader(self):
         assert_equal(self.subhdr._get_frame_offset(), 1536)
         dat = self.subhdr.raw_data_from_fileobj()
         assert_equal(dat.shape, self.subhdr.get_shape())
-        self.subhdr.subheaders[0]['scale_factor']
         assert_equal(self.subhdr.subheaders[0]['scale_factor'].item(), 1.0)
         ecat_calib_factor = self.hdr['ecat_calibration_factor']
         assert_equal(ecat_calib_factor, 25007614.0)