chore(cargo): add crate metadata and strict rust/clippy lint baseline#2
Merged
mgerhold merged 54 commits intoApr 28, 2026
Merged
Conversation
Collaborator
|
Gonna look into this next week. Thanks a lot in advance! 🙏 |
Replace let _ = ... patterns with drop(...) for Result return values in spawned thread closures. This makes the intent explicit and addresses all let-underscore-drop warnings.
Make child, control, output, and servers modules private since they are only used internally by the app module. Suppress the unused-crate warning in main.rs with a reason attribute explaining the transitive dependency through the stdioxide library.
Co-authored-by: Copilot <copilot@github.com>
Add explicit 'use crate_name as _;' imports in each test file to acknowledge dev-dependencies that are available but not used by that specific test target. This resolves unused-crate-dependencies warnings.
Co-authored-by: Copilot <copilot@github.com>
Change pub(crate) to pub for items in private modules (child, control, output, servers). Since the modules themselves are private, pub(crate) is redundant - items are already scoped to the crate.
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…ippy Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
MarioMottl
approved these changes
Apr 28, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
b-dreissigacker
approved these changes
Apr 28, 2026
Collaborator
|
@grouvie @MarioMottl Thanks again 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive
[lints.rust]and[lints.clippy]configuration to standardize linting across the project.Add crate metadata in
Cargo.toml(repository,readme, and commented placeholders fordescription,keywords,categories).