Skip to content

Commit 70be832

Browse files
committed
fix Error: MISSING_COMMA: detected by covscan
This commit fixes the following errors found by conscan, Error: MISSING_COMMA: [#def3] python-dmidecode-3.12.2/src/dmidecode.c:1375: missing_comma: In the initialization of "upgrade", a suspicious concatenated string ""Socket BGA1288Socket rPGA988B"" is produced due to a missing comma between lines. python-dmidecode-3.12.2/src/dmidecode.c:1375: remediation: Did you intend to separate these two string literals with a comma? # 1373| "Socket LGA1567", # 1374| "Socket PGA988A", # 1375|-> "Socket BGA1288" /* 0x20 */ # 1376| "Socket rPGA988B", # 1377| "Socket BGA1023", Error: MISSING_COMMA: [#def4] python-dmidecode-3.12.2/src/dmidecode.c:1843: missing_comma: In the initialization of "type", a suspicious concatenated string ""64-way Set-associative20-way Set-associative"" is produced due to a missing comma between lines. python-dmidecode-3.12.2/src/dmidecode.c:1843: remediation: Did you intend to separate these two string literals with a comma? Error: MISSING_COMMA: [#def6] python-dmidecode-3.12.2/src/dmidecode.c:2868: missing_comma: In the initialization of "type", a suspicious concatenated string ""DDR3FBD2"" is produced. python-dmidecode-3.12.2/src/dmidecode.c:2868: remediation: Did you intend to separate these two string literals with a comma? # 2866| "Reserved", # 2867| "Reserved", # 2868|-> "DDR3" # 2869| "FBD2" /* 0x19 */ # 2870| }; # 1841| "32-way Set-associative", # 1842| "48-way Set-associative", # 1843|-> "64-way Set-associative" /* 0x0D */ # 1844| "20-way Set-associative" /* 0x0E */
1 parent 9e0371d commit 70be832

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/dmidecode.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1372,7 +1372,7 @@ void dmi_processor_upgrade(xmlNode *node, u8 code)
13721372
"Socket LGA1156",
13731373
"Socket LGA1567",
13741374
"Socket PGA988A",
1375-
"Socket BGA1288" /* 0x20 */
1375+
"Socket BGA1288", /* 0x20 */
13761376
"Socket rPGA988B",
13771377
"Socket BGA1023",
13781378
"Socket BGA1224",
@@ -1840,7 +1840,7 @@ void dmi_cache_associativity(xmlNode *node, u8 code)
18401840
"24-way Set-associative",
18411841
"32-way Set-associative",
18421842
"48-way Set-associative",
1843-
"64-way Set-associative" /* 0x0D */
1843+
"64-way Set-associative", /* 0x0D */
18441844
"20-way Set-associative" /* 0x0E */
18451845
};
18461846
xmlNode *data_n = xmlNewChild(node, NULL, (xmlChar *) "Associativity", NULL);
@@ -2865,7 +2865,7 @@ void dmi_memory_device_type(xmlNode *node, u8 code)
28652865
"Reserved",
28662866
"Reserved",
28672867
"Reserved",
2868-
"DDR3"
2868+
"DDR3",
28692869
"FBD2" /* 0x19 */
28702870
};
28712871
xmlNode *data_n = xmlNewChild(node, NULL, (xmlChar *) "Type", NULL);

0 commit comments

Comments
 (0)