Pass position in input to `begin_game`

[parszab]

Thanks for the library, it is fantastic!

However, to implement a tool that would require the position of a particular PNG in the file it would be necessary to know the byte position of each game in the input.

(For pgn-extract like functionality e.g. to get the PGNs that match a search or to return the position of the invalid PGNs in a file.)

Would it be possible to pass the input position in begin_game?

[tigerros]

We should return how many bytes were read in each of the BufferedReader functions. That would let you know where does every PGN begin and end. It's also cheap and idiomatic.

[parszab]

We should return how many bytes were read in each of the BufferedReader functions. That would let you know where does every PGN begin and end. It's also cheap and idiomatic.

I'm sorry @tigerros -- van you explain / point me to a resource how I could do this on the client side?

[tigerros]

We should return how many bytes were read in each of the BufferedReader functions. That would let you know where does every PGN begin and end. It's also cheap and idiomatic.

I'm sorry @tigerros -- van you explain / point me to a resource how I could do this on the client side?

You can't do this yourself, there needs to be a change in the library. I'll make a PR once niklasf/rust-pgn-reader#52 and niklasf/rust-pgn-reader#53 are resolved since there would be a bunch of conflicts otherwise.

[tigerros]

@parszab this works in the meantime: https://gist.github.com/tigerros/eab96950f6af7daa868299af59d18c62. It's ugly because BufferedReader::into_inner can't be converted back to a BufferedReader of the same type. I made a fix for that in niklasf/rust-pgn-reader#55

[parszab]

@parszab this works in the meantime: https://gist.github.com/tigerros/eab96950f6af7daa868299af59d18c62. It's ugly because BufferedReader::into_inner can't be converted back to a BufferedReader of the same type. I made a fix for that in #55

@tigerros -- I appreciate this! It does the trick but is a bit convoluted on the client side. As I understand you plan to hide this behind the API? Is there an issue for this I could follow?

[tigerros]

@parszab this works in the meantime: https://gist.github.com/tigerros/eab96950f6af7daa868299af59d18c62. It's ugly because BufferedReader::into_inner can't be converted back to a BufferedReader of the same type. I made a fix for that in #55

@tigerros -- I appreciate this! It does the trick but is a bit convoluted on the client side. As I understand you plan to hide this behind the API? Is there an issue for this I could follow?

As I said, I'll make a PR to return the amount of bytes read but I'll wait until the other PRs are merged first so I don't need to resolve conflicts.

If you need it right now, niklasf/rust-pgn-reader#55 did get merged, which allows you to convert a BufferedReader::into_inner back into a BufferedReader with BufferedReader::from_buffer (doc and code here). However, you need to depend on the latest GitHub version of shakmaty to use it (pgn-reader now lives there, this repo will be archived). Just do this:

[dependencies]
pgn-reader = { git = "https://github.com/niklasf/shakmaty", branch = "main" }

Optionally add rev = "52e4cd66edcb93adddf2d1079498062423d1a6a5" if you don't want it to automatically sync changes.

[parszab]

If you need it right now...

No rush, thanks, I appreciate your efforts! Fantastic library!

[tigerros]

You should appreciate niklas more. I just made a couple of PRs :)

[parszab]

You should appreciate niklas more. I just made a couple of PRs :)

Oh, I do, for a long time, started with using Python chess 7 years ago! :)