♻️ Added withDisplayName string helper

Author: nicoverbruggen

phpmon/Common/Extensions/StringExtension.swift

@@ -164,4 +164,10 @@ extension String {
             of: "^[0-9]*$", // 1
             options: .regularExpression) != nil
     }
+
+    // MARK: - Helpers
+
+    var withDisplayName: String {
+        return self.replacing("PHP Monitor", with: App.displayName)
+    }
 }

phpmon/Domain/App/App.swift

@@ -17,8 +17,8 @@ class App {
     /** Use to determine whether a loaded testable configuration is being used. */
     static var hasLoadedTestableConfiguration: Bool = false
 
-    /** The name of the app. Has EAP suffixed when an actual EAP build. */
-    static var name: String {
+    /** The display name of the app, as declared in Info.plist. */
+    static var displayName: String {
         return Bundle.main.infoDictionary?["CFBundleName"] as! String
     }
 

phpmon/Domain/Menu/StatusMenu+Items.swift

@@ -127,9 +127,9 @@ extension StatusMenu {
     @MainActor func addCoreMenuItems() {
         addItems([
             NSMenuItem.separator(),
-            NSMenuItem(title: "mi_about".localized.replacing("PHP Monitor", with: App.name),
+            NSMenuItem(title: "mi_about".localized.withDisplayName,
                        action: #selector(MainMenu.openAbout)),
-            NSMenuItem(title: "mi_quit".localized.replacing("PHP Monitor", with: App.name),
+            NSMenuItem(title: "mi_quit".localized.withDisplayName,
                        action: #selector(MainMenu.terminateApp), keyEquivalent: "q")
         ])
     }