Use Type as PropertyPart CustomType instead of only name (#347)

* Don't use only name for PropertyPart.CustomType

- Use the constructor of TypeReference with Type argument instead of the
  constructor with string argument in the overloads of CustomType in
  PropertyPart where an explicit Type is passed.
- This fixes the problem that Fluent NHibernate may map a wrong type
  for a property although an explicit type was passed to CustomType.
  This problem can happen if there are two types with names which only
  differ in upper / lower case. Such similar type names can e.g. be
  caused by obfuscation tools.

* Adapt tests to new behaviour of PropertyPart

- The production code of the CustomType overloads of PropertyPart was
  changed to use a different constructor of TypeReference when an
  explicit Type was given. This caused two tests to fail although the
  code still should work correctly.
- Change failing tests to expect the new behaviour.

+semver:fix

Author: visubesy

src/FluentNHibernate.Testing/ConventionsTests/OverridingFluentInterface/PropertyConventionTests.cs

@@ -65,7 +65,7 @@ public void TypeShouldntBeOverwritten()
 
         Convention(x => x.CustomType<int>());
 
-        VerifyModel(x => x.Type.Name.ShouldEqual(typeof(CustomUserType).AssemblyQualifiedName));
+        VerifyModel(x => x.Type.GetUnderlyingSystemType().ShouldEqual(typeof(CustomUserType)));
     }
 
     [Test]
@@ -285,4 +285,4 @@ void VerifyModel(Action<PropertyMapping> modelVerification)
     }
 
     #endregion
-}
+}

src/FluentNHibernate.Testing/DomainModel/Mapping/ClassMapConventionsTester.cs

@@ -108,6 +108,6 @@ public void EnumsDontGetTypeOverriddenByConventionsIfExplicitlySet()
     {
         new MappingTester<MappedObject>()
             .ForMapping(m => m.Map(x => x.Color).CustomType(typeof(int)))
-            .Element("class/property[@name='Color']").HasAttribute("type", typeof(int).Name);
+            .Element("class/property[@name='Color']").HasAttribute("type", typeof(int).AssemblyQualifiedName);
     }
-}
+}

src/FluentNHibernate/Mapping/PropertyPart.cs

@@ -12,8 +12,8 @@ public class PropertyPart : IPropertyMappingProvider
 {
     readonly Member member;
     readonly Type parentType;
-    readonly AttributeStore attributes = new AttributeStore();
-    readonly AttributeStore columnAttributes = new AttributeStore();
+    readonly AttributeStore attributes = new();
+    readonly AttributeStore columnAttributes = new();
 
     bool nextBool = true;
 
@@ -171,7 +171,8 @@ public PropertyPart CustomType(Type type)
         if (typeof(ICompositeUserType).IsAssignableFrom(type))
             AddColumnsFromCompositeUserType(type);
 
-        return CustomType(TypeMapping.GetTypeString(type));
+        attributes.Set("Type", Layer.UserSupplied, new TypeReference(type));
+        return this;
     }
 
     /// <summary>
@@ -194,11 +195,7 @@ public PropertyPart CustomType(string type)
     public PropertyPart CustomType(Func<Type, Type> typeFunc)
     {
         var type = typeFunc.Invoke(member.PropertyType);
-
-        if (typeof(ICompositeUserType).IsAssignableFrom(type))
-            AddColumnsFromCompositeUserType(type);
-
-        return CustomType(TypeMapping.GetTypeString(type));
+        return CustomType(type);
     }
 
     void AddColumnsFromCompositeUserType(Type compositeUserType)