Tests: add coverage for upstream cache Age handling#42
Open
anchmelev wants to merge 2 commits into
Open
Conversation
2 tasks
sindhushiv
moved this from New
to External Pull Requests
in NGINX OSS Unified Workspace
anchmelev
force-pushed
the
issue-1234-upstream-cache-age-tests
branch
from
2642039 to
0ea3975
Compare
The test used regular expressions with "{,n}" quantifier with empty
lower bound, which is only available starting with Perl 5.34.0. Further,
it used variable-length look-behind assertions, which are only available
starting with Perl 5.30.0 and emit experimental warning till Perl 5.36.0.
Fix is to rewrite regular expressions in question using "(?>pattern)"
instead (an independent subexpression), which is available since at least
Perl 5.005.
anchmelev
force-pushed
the
issue-1234-upstream-cache-age-tests
branch
from
0ea3975 to
89f4dc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add proxy cache tests for
Ageheader handling.This PR adds tests covering:
AgeAgearrives before or afterCache-Controlproxy_ignore_headers Age$upstream_cache_ageon cached and non-cached responsesThis PR is a companion to nginx/nginx#1234.
Validated with:
TEST_NGINX_BINARY=/Users/chmelev.andrey/dev/open-source/nginx/objs/nginx prove -v ./proxy_cache_age.tChecklist
README.mdand/orCHANGELOG.md).