Skip to content

Version parsing regex can't parse some valid version #164

@fabianegli

Description

@fabianegli

openms_version_regex = r"([0-9][.][0-9][.][0-9])"

The above regex r"([0-9][.][0-9][.][0-9])" doesn't match the historic openMS version 1.11.0. I think the regex should be either expanded to allow multi digit main, minor and bug release versions or maybe even be expanded to match all Semantic Versioning 2.0.0, if that is indeed what openMS (and the other tools) adheres to. The SemVer website contains regexes with and without named groups: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions