From 00100427bea5a166746a5d968d5651776fb4e9bc Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 25 Mar 2026 16:10:35 -0400 Subject: [PATCH 1/2] feat(files_external/s3): Adjust auth meth/parameter field names Signed-off-by: Josh --- apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php b/apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php index cd03999f3cb17..1bf479b4eac46 100644 --- a/apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php +++ b/apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php @@ -23,10 +23,10 @@ public function __construct(IL10N $l) { $this ->setIdentifier('amazons3::accesskey') ->setScheme(self::SCHEME_AMAZONS3_ACCESSKEY) - ->setText($l->t('Access key')) + ->setText($l->t('Static credentials')) ->addParameters([ - new DefinitionParameter('key', $l->t('Access key')), - (new DefinitionParameter('secret', $l->t('Secret key'))) + new DefinitionParameter('key', $l->t('Access key ID')), + (new DefinitionParameter('secret', $l->t('Secret access key'))) ->setType(DefinitionParameter::VALUE_PASSWORD), ]); } From b7bdd7673157dda3228cc4455a8872af2fb3ec9e Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 25 Mar 2026 16:21:35 -0400 Subject: [PATCH 2/2] feat(files_external/s3): rename legacy signature (v2) for clarity Avoid the use of "authentication" here since this is really about signing compatibility, not the source of credentials. Also prefix with "Use" for UI consistency. Signed-off-by: Josh --- apps/files_external/lib/Lib/Backend/AmazonS3.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files_external/lib/Lib/Backend/AmazonS3.php b/apps/files_external/lib/Lib/Backend/AmazonS3.php index 06a1a67d72340..82ea7298e09cd 100644 --- a/apps/files_external/lib/Lib/Backend/AmazonS3.php +++ b/apps/files_external/lib/Lib/Backend/AmazonS3.php @@ -41,7 +41,7 @@ public function __construct(IL10N $l, AccessKey $legacyAuth) { ->setDefaultValue(true), (new DefinitionParameter('use_path_style', $l->t('Enable Path Style'))) ->setType(DefinitionParameter::VALUE_BOOLEAN), - (new DefinitionParameter('legacy_auth', $l->t('Legacy (v2) authentication'))) + (new DefinitionParameter('legacy_auth', $l->t('Use Legacy S3 signing (v2)'))) ->setType(DefinitionParameter::VALUE_BOOLEAN), (new DefinitionParameter('useMultipartCopy', $l->t('Enable multipart copy'))) ->setType(DefinitionParameter::VALUE_BOOLEAN)