From 19f260a22053247f6141c72184b117a4540594a2 Mon Sep 17 00:00:00 2001 From: Strobel Pierre Date: Tue, 3 Feb 2026 15:43:03 +0100 Subject: [PATCH] fix: enable deno_core feature for JavaScript expression evaluation Since version 1.3.0, users get the error: "ExecutionErr: Error during isolated evaluation of expression: Deno core is not enabled" This happens because the `deno_core` Cargo feature was not enabled when building Windmill. This feature is required for Windmill to evaluate JavaScript/TypeScript expressions in workflows (e.g., `flow_input.event.values[0].value[0].id`). The `deno_core` feature enables the embedded JavaScript runtime based on deno_core and V8. This is different from the external Deno binary (`/usr/bin/deno`) which is already included in the image. Fixes #129 Signed-off-by: Strobel Pierre --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c15d96e..bce715f 100644 --- a/Makefile +++ b/Makefile @@ -56,7 +56,7 @@ build-push: docker login ghcr.io docker buildx build --push \ --build-arg VITE_BASE_URL=/index.php/apps/app_api/proxy/flow \ - --build-arg features=python \ + --build-arg features=deno_core,python \ --platform linux/arm64/v8,linux/amd64 \ --tag ghcr.io/nextcloud/$(APP_ID):$(APP_VERSION) \ --file windmill_src/Dockerfile \ @@ -66,7 +66,7 @@ build-push: build-amd64: docker buildx build --load \ --build-arg VITE_BASE_URL=/index.php/apps/app_api/proxy/flow \ - --build-arg features=python \ + --build-arg features=deno_core,python \ --platform linux/amd64 \ --tag ghcr.io/nextcloud/$(APP_ID):$(APP_VERSION) \ --file windmill_src/Dockerfile \