From 152a222d7b0dc7e0c1198aacf980fe103bf97786 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Fri, 30 Jan 2026 15:41:13 +0100 Subject: [PATCH 1/6] fix(share): internal link alignment Signed-off-by: alperozturk96 --- .../main/res/layout/file_details_share_internal_share_link.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/layout/file_details_share_internal_share_link.xml b/app/src/main/res/layout/file_details_share_internal_share_link.xml index 8bc5eb8be1de..ddafa2b559d4 100644 --- a/app/src/main/res/layout/file_details_share_internal_share_link.xml +++ b/app/src/main/res/layout/file_details_share_internal_share_link.xml @@ -22,7 +22,7 @@ android:background="@drawable/round_bgnd" android:contentDescription="@string/share" android:id="@+id/copy_internal_link_icon" - android:layout_gravity="top" + android:layout_gravity="center" android:layout_height="@dimen/share_icon_size" android:layout_marginEnd="@dimen/standard_margin" android:layout_marginStart="@dimen/standard_margin" From 0b18e647585e01b147633e706fe84e60aeefe5f3 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Fri, 30 Jan 2026 16:09:28 +0100 Subject: [PATCH 2/6] fix(share): drop down icon visibility Signed-off-by: alperozturk96 --- .../com/owncloud/android/ui/adapter/LinkShareViewHolder.kt | 6 +++--- .../main/res/layout/file_details_share_link_share_item.xml | 7 ++++--- app/src/main/res/layout/file_details_share_share_item.xml | 4 +++- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt b/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt index 3ebe6b08d380..83b9d152a4dd 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt @@ -134,11 +134,11 @@ internal class LinkShareViewHolder(itemView: View) : RecyclerView.ViewHolder(ite if (TextUtils.isEmpty(permissionName) || (isSecureFileDrop(publicShare) && encrypted)) { binding.permissionName.visibility = View.GONE - return + } else { + binding.permissionName.visibility = View.VISIBLE + binding.permissionName.text = permissionName } - binding.permissionName.text = permissionName - binding.permissionName.visibility = View.VISIBLE viewThemeUtils?.androidx?.colorPrimaryTextViewElement(binding.permissionName) } diff --git a/app/src/main/res/layout/file_details_share_link_share_item.xml b/app/src/main/res/layout/file_details_share_link_share_item.xml index e7cf42512914..12ab0a9a85c0 100644 --- a/app/src/main/res/layout/file_details_share_link_share_item.xml +++ b/app/src/main/res/layout/file_details_share_link_share_item.xml @@ -63,14 +63,15 @@ diff --git a/app/src/main/res/layout/file_details_share_share_item.xml b/app/src/main/res/layout/file_details_share_share_item.xml index facdb0cdaa42..5f3003c0d53c 100644 --- a/app/src/main/res/layout/file_details_share_share_item.xml +++ b/app/src/main/res/layout/file_details_share_share_item.xml @@ -51,14 +51,16 @@ From 8af71fda0904e3333fd3ff9c2f85c3977e695e78 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Fri, 30 Jan 2026 16:30:44 +0100 Subject: [PATCH 3/6] make imageview material icon button Signed-off-by: alperozturk96 --- .../file_details_share_link_share_item.xml | 23 ++++++++++++------- .../layout/file_details_share_share_item.xml | 12 ++++++---- 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/app/src/main/res/layout/file_details_share_link_share_item.xml b/app/src/main/res/layout/file_details_share_link_share_item.xml index 12ab0a9a85c0..5625d31f2382 100644 --- a/app/src/main/res/layout/file_details_share_link_share_item.xml +++ b/app/src/main/res/layout/file_details_share_link_share_item.xml @@ -76,10 +76,11 @@ android:textSize="@dimen/two_line_secondary_text_size" /> - + app:iconTint="@color/text_color" + app:icon="@drawable/ic_content_copy" + app:iconGravity="textStart" /> - + app:icon="@drawable/ic_dots_vertical" + app:iconTint="@color/text_color" + app:iconGravity="textStart" /> diff --git a/app/src/main/res/layout/file_details_share_share_item.xml b/app/src/main/res/layout/file_details_share_share_item.xml index 5f3003c0d53c..3ee12388b13b 100644 --- a/app/src/main/res/layout/file_details_share_share_item.xml +++ b/app/src/main/res/layout/file_details_share_share_item.xml @@ -65,12 +65,16 @@ tools:text="@string/placeholder_view_only" /> - + app:icon="@drawable/ic_dots_vertical" + app:iconTint="@color/text_color" + app:iconGravity="textStart" /> From b160bc47633b123224741054f09893dd29742751 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Fri, 30 Jan 2026 16:52:03 +0100 Subject: [PATCH 4/6] make imageview material icon button Signed-off-by: alperozturk96 --- .../main/res/layout/file_details_share_link_share_item.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/file_details_share_link_share_item.xml b/app/src/main/res/layout/file_details_share_link_share_item.xml index 5625d31f2382..7663b67f341f 100644 --- a/app/src/main/res/layout/file_details_share_link_share_item.xml +++ b/app/src/main/res/layout/file_details_share_link_share_item.xml @@ -70,8 +70,9 @@ android:gravity="center_vertical" android:singleLine="true" tools:text="@string/placeholder_view_only" - android:drawablePadding="4dp" - app:drawableEndCompat="@drawable/ic_baseline_arrow_drop_down_24" app:drawableTint="@color/primary" + android:drawablePadding="@dimen/standard_quarter_margin" + app:drawableEndCompat="@drawable/ic_baseline_arrow_drop_down_24" + app:drawableTint="@color/primary" android:textColor="@color/primary" android:textSize="@dimen/two_line_secondary_text_size" /> From 453f0fed48b2a9d4a60e40d894735c63672fed8e Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Wed, 4 Feb 2026 15:30:28 +0100 Subject: [PATCH 5/6] color list item color Signed-off-by: alperozturk96 --- app/src/main/res/layout/grid_item.xml | 3 +++ app/src/main/res/layout/list_item.xml | 4 ++++ app/src/main/res/layout/recommended_file_item.xml | 1 + 3 files changed, 8 insertions(+) diff --git a/app/src/main/res/layout/grid_item.xml b/app/src/main/res/layout/grid_item.xml index ddbbc8c627c3..4ce95c7cb92c 100644 --- a/app/src/main/res/layout/grid_item.xml +++ b/app/src/main/res/layout/grid_item.xml @@ -139,6 +139,7 @@ android:src="@android:drawable/checkbox_off_background" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" + app:tint="@color/text_color" tools:visibility="visible" /> @@ -229,6 +231,7 @@ app:layout_constraintTop_toBottomOf="@id/thumbnail" app:srcCompat="@drawable/ic_dots_vertical" tools:ignore="TouchTargetSizeCheck" + app:tint="@color/text_color" tools:visibility="visible" /> diff --git a/app/src/main/res/layout/list_item.xml b/app/src/main/res/layout/list_item.xml index 8717f2ffc7aa..de2bacafc86a 100644 --- a/app/src/main/res/layout/list_item.xml +++ b/app/src/main/res/layout/list_item.xml @@ -246,6 +246,7 @@ android:paddingEnd="@dimen/list_item_share_right_margin" android:src="@drawable/ic_comment" android:visibility="gone" + app:tint="@color/text_color" tools:visibility="visible" /> diff --git a/app/src/main/res/layout/recommended_file_item.xml b/app/src/main/res/layout/recommended_file_item.xml index 0d91762076a2..e8e5bbd6ebeb 100644 --- a/app/src/main/res/layout/recommended_file_item.xml +++ b/app/src/main/res/layout/recommended_file_item.xml @@ -199,6 +199,7 @@ android:id="@+id/more" android:layout_width="@dimen/grid_bottom_view_height" android:layout_height="@dimen/grid_bottom_view_height" + app:tint="@color/text_color" android:layout_marginHorizontal="@dimen/standard_half_margin" android:contentDescription="@string/overflow_menu" app:layout_constraintStart_toEndOf="@+id/filename_and_reason_layout" From a00f3b1d6b415ebd7c8537c24bad96d68e82372d Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Thu, 5 Feb 2026 10:51:42 +0100 Subject: [PATCH 6/6] revert colors Signed-off-by: alperozturk96 --- .../main/res/layout/file_details_share_link_share_item.xml | 4 ++-- app/src/main/res/layout/file_details_share_share_item.xml | 2 +- app/src/main/res/layout/grid_item.xml | 3 --- app/src/main/res/layout/list_item.xml | 4 ---- app/src/main/res/layout/recommended_file_item.xml | 1 - 5 files changed, 3 insertions(+), 11 deletions(-) diff --git a/app/src/main/res/layout/file_details_share_link_share_item.xml b/app/src/main/res/layout/file_details_share_link_share_item.xml index 7663b67f341f..4e063e1a1ad2 100644 --- a/app/src/main/res/layout/file_details_share_link_share_item.xml +++ b/app/src/main/res/layout/file_details_share_link_share_item.xml @@ -89,7 +89,7 @@ android:paddingEnd="@dimen/standard_padding" android:paddingBottom="@dimen/standard_quarter_margin" android:scaleType="fitCenter" - app:iconTint="@color/text_color" + app:iconTint="@color/secondary_text_color" app:icon="@drawable/ic_content_copy" app:iconGravity="textStart" /> @@ -103,7 +103,7 @@ android:paddingStart="@dimen/standard_padding" android:paddingEnd="@dimen/standard_padding" app:icon="@drawable/ic_dots_vertical" - app:iconTint="@color/text_color" + app:iconTint="@color/secondary_text_color" app:iconGravity="textStart" /> diff --git a/app/src/main/res/layout/file_details_share_share_item.xml b/app/src/main/res/layout/file_details_share_share_item.xml index 3ee12388b13b..0ae9e82c0588 100644 --- a/app/src/main/res/layout/file_details_share_share_item.xml +++ b/app/src/main/res/layout/file_details_share_share_item.xml @@ -75,6 +75,6 @@ android:paddingStart="@dimen/standard_padding" android:paddingEnd="@dimen/standard_padding" app:icon="@drawable/ic_dots_vertical" - app:iconTint="@color/text_color" + app:iconTint="@color/secondary_text_color" app:iconGravity="textStart" /> diff --git a/app/src/main/res/layout/grid_item.xml b/app/src/main/res/layout/grid_item.xml index 4ce95c7cb92c..ddbbc8c627c3 100644 --- a/app/src/main/res/layout/grid_item.xml +++ b/app/src/main/res/layout/grid_item.xml @@ -139,7 +139,6 @@ android:src="@android:drawable/checkbox_off_background" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" - app:tint="@color/text_color" tools:visibility="visible" /> @@ -231,7 +229,6 @@ app:layout_constraintTop_toBottomOf="@id/thumbnail" app:srcCompat="@drawable/ic_dots_vertical" tools:ignore="TouchTargetSizeCheck" - app:tint="@color/text_color" tools:visibility="visible" /> diff --git a/app/src/main/res/layout/list_item.xml b/app/src/main/res/layout/list_item.xml index de2bacafc86a..8717f2ffc7aa 100644 --- a/app/src/main/res/layout/list_item.xml +++ b/app/src/main/res/layout/list_item.xml @@ -246,7 +246,6 @@ android:paddingEnd="@dimen/list_item_share_right_margin" android:src="@drawable/ic_comment" android:visibility="gone" - app:tint="@color/text_color" tools:visibility="visible" /> diff --git a/app/src/main/res/layout/recommended_file_item.xml b/app/src/main/res/layout/recommended_file_item.xml index e8e5bbd6ebeb..0d91762076a2 100644 --- a/app/src/main/res/layout/recommended_file_item.xml +++ b/app/src/main/res/layout/recommended_file_item.xml @@ -199,7 +199,6 @@ android:id="@+id/more" android:layout_width="@dimen/grid_bottom_view_height" android:layout_height="@dimen/grid_bottom_view_height" - app:tint="@color/text_color" android:layout_marginHorizontal="@dimen/standard_half_margin" android:contentDescription="@string/overflow_menu" app:layout_constraintStart_toEndOf="@+id/filename_and_reason_layout"