From f2728855831b65306466490feb65b7d154090c6d Mon Sep 17 00:00:00 2001 From: tobiasKaminsky Date: Wed, 7 May 2025 16:08:25 +0200 Subject: [PATCH 1/2] fix twitter/X test Signed-off-by: tobiasKaminsky --- .../lib/resources/users/SetUserInfoRemoteOperationIT.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/library/src/androidTest/java/com/owncloud/android/lib/resources/users/SetUserInfoRemoteOperationIT.java b/library/src/androidTest/java/com/owncloud/android/lib/resources/users/SetUserInfoRemoteOperationIT.java index d5a39aa99c..973fa48a52 100644 --- a/library/src/androidTest/java/com/owncloud/android/lib/resources/users/SetUserInfoRemoteOperationIT.java +++ b/library/src/androidTest/java/com/owncloud/android/lib/resources/users/SetUserInfoRemoteOperationIT.java @@ -133,14 +133,15 @@ public void testSetTwitter() { RemoteOperationResult userInfo = new GetUserInfoRemoteOperation().execute(nextcloudClient); assertTrue(userInfo.isSuccess()); String oldValue = userInfo.getResultData().getTwitter(); + String newValue = "Nextclouders"; // set - assertTrue(new SetUserInfoRemoteOperation(SetUserInfoRemoteOperation.Field.TWITTER, "@Nextclouders") + assertTrue(new SetUserInfoRemoteOperation(SetUserInfoRemoteOperation.Field.TWITTER, newValue) .execute(nextcloudClient).isSuccess()); userInfo = new GetUserInfoRemoteOperation().execute(nextcloudClient); assertTrue(userInfo.isSuccess()); - assertEquals("@Nextclouders", userInfo.getResultData().getTwitter()); + assertEquals(newValue, userInfo.getResultData().getTwitter()); // reset assertTrue(new SetUserInfoRemoteOperation(SetUserInfoRemoteOperation.Field.TWITTER, oldValue) From fbd880e502aefa796cb2a0ca25cdc41e139cdafa Mon Sep 17 00:00:00 2001 From: tobiasKaminsky Date: Wed, 7 May 2025 16:23:02 +0200 Subject: [PATCH 2/2] add some debug output Signed-off-by: tobiasKaminsky --- .../owncloud/android/lib/common/operations/RemoveShareIT.java | 2 +- .../android/lib/resources/files/FilesDownloadLimitIT.kt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/library/src/androidTest/java/com/owncloud/android/lib/common/operations/RemoveShareIT.java b/library/src/androidTest/java/com/owncloud/android/lib/common/operations/RemoveShareIT.java index 70171e560e..3c3f2b00ce 100644 --- a/library/src/androidTest/java/com/owncloud/android/lib/common/operations/RemoveShareIT.java +++ b/library/src/androidTest/java/com/owncloud/android/lib/common/operations/RemoveShareIT.java @@ -44,7 +44,7 @@ public void testRemoveShare() throws IOException { false, "", 1).execute(client); - assertTrue(result.isSuccess()); + assertTrue(result.getLogMessage(), result.isSuccess()); OCShare ocShare = result.getResultData().get(0); diff --git a/library/src/androidTest/java/com/owncloud/android/lib/resources/files/FilesDownloadLimitIT.kt b/library/src/androidTest/java/com/owncloud/android/lib/resources/files/FilesDownloadLimitIT.kt index 03c852d5b6..d17c7b57e6 100644 --- a/library/src/androidTest/java/com/owncloud/android/lib/resources/files/FilesDownloadLimitIT.kt +++ b/library/src/androidTest/java/com/owncloud/android/lib/resources/files/FilesDownloadLimitIT.kt @@ -18,6 +18,7 @@ import com.owncloud.android.lib.resources.status.GetCapabilitiesRemoteOperation import com.owncloud.android.lib.resources.status.NextcloudVersion import com.owncloud.android.lib.resources.status.OCCapability import junit.framework.TestCase.assertEquals +import junit.framework.TestCase.assertTrue import org.junit.Before import org.junit.Test @@ -102,7 +103,7 @@ class FilesDownloadLimitIT : AbstractIT() { 1 ).execute(client) - assert(result.isSuccess) + assertTrue(result.getLogMessage(), result.isSuccess) val share = result.resultData.first() assert(share.token != null) return share