Fix lint

- remove redundant exception handling

Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>

Author: ZetaTom

library/src/androidTest/java/com/owncloud/android/lib/resources/files/FilesDownloadLimitIT.kt

@@ -35,6 +35,7 @@ class FilesDownloadLimitIT : AbstractIT() {
     }
 
     @Test
+    @Suppress("Detekt.MagicNumber")
     fun downloadLimit() {
         val share = createTestShare()
         val limit = 5

library/src/main/java/com/nextcloud/android/lib/resources/files/GetFilesDownloadLimitRemoteOperation.kt

@@ -26,8 +26,7 @@ class GetFilesDownloadLimitRemoteOperation
     ) : OCSRemoteOperation<List<FileDownloadLimit>>() {
         @Deprecated("Deprecated in Java")
         override fun run(client: OwnCloudClient): RemoteOperationResult<List<FileDownloadLimit>> {
-            var result: RemoteOperationResult<List<FileDownloadLimit>>
-            var propFindMethod: PropFindMethod? = null
+            val result: RemoteOperationResult<List<FileDownloadLimit>>
             val propSet = DavPropertyNameSet()
             val depth = if (subfiles) DavConstants.DEPTH_1 else DavConstants.DEPTH_0
 
@@ -36,33 +35,29 @@ class GetFilesDownloadLimitRemoteOperation
                 Namespace.getNamespace(WebdavEntry.NAMESPACE_NC)
             )
 
-            try {
-                propFindMethod = PropFindMethod(client.getFilesDavUri(remotePath), propSet, depth)
+            val propFindMethod = PropFindMethod(client.getFilesDavUri(remotePath), propSet, depth)
 
-                val status = client.executeMethod(propFindMethod)
+            val status = client.executeMethod(propFindMethod)
 
-                if (status == HttpStatus.SC_MULTI_STATUS || status == HttpStatus.SC_OK) {
-                    val response = propFindMethod.responseBodyAsMultiStatus
+            if (status == HttpStatus.SC_MULTI_STATUS || status == HttpStatus.SC_OK) {
+                val response = propFindMethod.responseBodyAsMultiStatus
 
-                    val fileDownloadLimits =
-                        response.responses.flatMap {
-                            val webdavEntry = WebdavEntry(it, client.filesDavUri.encodedPath!!)
-                            webdavEntry.fileDownloadLimit
-                        }
+                val fileDownloadLimits =
+                    response.responses.flatMap {
+                        val webdavEntry = WebdavEntry(it, client.filesDavUri.encodedPath!!)
+                        webdavEntry.fileDownloadLimit
+                    }
 
-                    result = RemoteOperationResult(true, propFindMethod)
-                    result.resultData = fileDownloadLimits
-                } else {
-                    result = RemoteOperationResult(false, propFindMethod)
-                    client.exhaustResponse(propFindMethod.responseBodyAsStream)
-                }
-            } catch (e: Exception) {
-                result = RemoteOperationResult(e)
-                Log_OC.e(TAG, "Exception while reading download limit", e)
-            } finally {
-                propFindMethod?.releaseConnection()
+                result = RemoteOperationResult(true, propFindMethod)
+                result.resultData = fileDownloadLimits
+            } else {
+                Log_OC.e(TAG, "Failed to get download limit")
+                result = RemoteOperationResult(false, propFindMethod)
+                client.exhaustResponse(propFindMethod.responseBodyAsStream)
             }
 
+            propFindMethod.releaseConnection()
+
             return result
         }
 

library/src/main/java/com/nextcloud/android/lib/resources/files/RemoveFilesDownloadLimitRemoteOperation.kt

@@ -18,29 +18,23 @@ class RemoveFilesDownloadLimitRemoteOperation(
     val token: String
 ) : OCSRemoteOperation<Void>() {
     override fun run(client: NextcloudClient): RemoteOperationResult<Void> {
-        var result: RemoteOperationResult<Void>
-        var deleteMethod: DeleteMethod? = null
-
-        try {
-            val url = client.baseUri.toString() + String.format(FILES_DOWNLOAD_LIMIT_ENDPOINT, token) + JSON_FORMAT
-            deleteMethod = DeleteMethod(url, true)
-
-            val status = deleteMethod.execute(client)
-
-            if (status == HttpStatus.SC_OK) {
-                result = RemoteOperationResult(true, deleteMethod)
-            } else {
-                result = RemoteOperationResult(false, deleteMethod)
-                Log_OC.e(TAG, "Failed to remove download limit")
-                Log_OC.e(TAG, "*** status code: " + status + "; response: " + deleteMethod.getResponseBodyAsString())
-            }
-        } catch (e: Exception) {
-            result = RemoteOperationResult(e)
-            Log_OC.e(TAG, "Exception while removing download limit", e)
-        } finally {
-            deleteMethod?.releaseConnection()
+        val result: RemoteOperationResult<Void>
+
+        val url = client.baseUri.toString() + String.format(FILES_DOWNLOAD_LIMIT_ENDPOINT, token) + JSON_FORMAT
+        val deleteMethod = DeleteMethod(url, true)
+
+        val status = deleteMethod.execute(client)
+
+        if (status == HttpStatus.SC_OK) {
+            result = RemoteOperationResult(true, deleteMethod)
+        } else {
+            result = RemoteOperationResult(false, deleteMethod)
+            Log_OC.e(TAG, "Failed to remove download limit")
+            Log_OC.e(TAG, "*** status code: " + status + "; response: " + deleteMethod.getResponseBodyAsString())
         }
 
+        deleteMethod.releaseConnection()
+
         return result
     }
 

library/src/main/java/com/nextcloud/android/lib/resources/files/SetFilesDownloadLimitRemoteOperation.kt

@@ -20,30 +20,24 @@ class SetFilesDownloadLimitRemoteOperation(
     val limit: Int
 ) : OCSRemoteOperation<Void>() {
     override fun run(client: NextcloudClient): RemoteOperationResult<Void> {
-        var result: RemoteOperationResult<Void>
-        var putMethod: PutMethod? = null
-
-        try {
-            val url = client.baseUri.toString() + String.format(FILES_DOWNLOAD_LIMIT_ENDPOINT, token)
-            val jsonRequestBody = JSONRequestBody("limit", limit.toString())
-            putMethod = PutMethod(url, true, jsonRequestBody.get())
-
-            val status = putMethod.execute(client)
-
-            if (status == HttpStatus.SC_OK) {
-                result = RemoteOperationResult(true, putMethod)
-            } else {
-                result = RemoteOperationResult(false, putMethod)
-                Log_OC.e(TAG, "Failed to set download limit")
-                Log_OC.e(TAG, "*** status code: " + status + "; response: " + putMethod.getResponseBodyAsString())
-            }
-        } catch (e: Exception) {
-            result = RemoteOperationResult(e)
-            Log_OC.e(TAG, "Exception while setting download limit", e)
-        } finally {
-            putMethod?.releaseConnection()
+        val result: RemoteOperationResult<Void>
+
+        val url = client.baseUri.toString() + String.format(FILES_DOWNLOAD_LIMIT_ENDPOINT, token)
+        val jsonRequestBody = JSONRequestBody("limit", limit.toString())
+        val putMethod = PutMethod(url, true, jsonRequestBody.get())
+
+        val status = putMethod.execute(client)
+
+        if (status == HttpStatus.SC_OK) {
+            result = RemoteOperationResult(true, putMethod)
+        } else {
+            result = RemoteOperationResult(false, putMethod)
+            Log_OC.e(TAG, "Failed to set download limit")
+            Log_OC.e(TAG, "*** status code: " + status + "; response: " + putMethod.getResponseBodyAsString())
         }
 
+        putMethod.releaseConnection()
+
         return result
     }