fix: Rename list_skills to skills_discover and fix linting errors

- Update __all__ export from list_skills to skills_discover
- Fix docstring examples to use correct function name
- Update test imports and test function to use skills_discover
- Fix all whitespace and import formatting issues in tests
- Update test to be async and mock correct methods

Author: joezhoujinjing

src/nexus_client/langgraph/prompt.py

@@ -12,7 +12,7 @@
 from nexus_client.langgraph.client import _get_nexus_client
 
 __all__ = [
-    "list_skills",
+    "skills_discover",
     "get_prompt_context",
 ]
 
@@ -74,19 +74,19 @@ async def skills_discover(
 
     Examples:
         >>> from langchain_core.runnables import RunnableConfig
-        >>> from nexus_client.langgraph.prompt import list_skills
+        >>> from nexus_client.langgraph.prompt import skills_discover
         >>>
         >>> config = RunnableConfig(metadata={
         ...     "x_auth": "Bearer sk-your-api-key",
         ...     "nexus_server_url": "http://localhost:8080"
         ... })
         >>>
         >>> # Get subscribed skills (default)
-        >>> result = await list_skills(config)
+        >>> result = await skills_discover(config)
         >>> print(f"Found {result['count']} skills")
         >>>
         >>> # Get all available skills
-        >>> result = await list_skills(config, filter="available")
+        >>> result = await skills_discover(config, filter="all")
         >>> print(f"Found {result['count']} available skills")
     """
     try:

tests/test_langgraph_tools.py

@@ -14,7 +14,7 @@
 
 if HAS_LANGGRAPH:
     from nexus_client import RemoteNexusFS
-    from nexus_client.langgraph import get_nexus_tools, list_skills
+    from nexus_client.langgraph import get_nexus_tools, skills_discover
     from nexus_client.langgraph.client import _get_nexus_client
 
 
@@ -79,33 +79,34 @@ def test_get_nexus_client_from_state(self):
 
 
 @pytest.mark.skipif(not HAS_LANGGRAPH, reason="LangGraph dependencies not installed")
-class TestListSkills:
-    """Test list_skills function."""
+class TestSkillsDiscover:
+    """Test skills_discover function."""
 
-    def test_list_skills(self):
-        """Test list_skills function."""
+    @pytest.mark.asyncio
+    async def test_skills_discover(self):
+        """Test skills_discover function."""
         config = RunnableConfig(
             metadata={
                 "x_auth": "Bearer sk-test-key",
                 "nexus_server_url": "http://localhost:8080",
             }
         )
 
-        # Mock the client to avoid actual RPC calls
-        # Need to patch both _get_nexus_client and the client's skills_list method
-        with patch("nexus_client.langgraph.tools._get_nexus_client") as mock_get_client:
-            mock_client = Mock(spec=RemoteNexusFS)
-            mock_client.skills_list.return_value = {
+        # Mock the async client to avoid actual RPC calls
+        # Need to patch _get_nexus_client and the client's skills_discover method
+        with patch("nexus_client.langgraph.prompt._get_nexus_client") as mock_get_client:
+            mock_client = Mock()
+            mock_client.skills_discover.return_value = {
                 "skills": [{"name": "test-skill", "description": "Test"}],
                 "count": 1,
             }
             mock_get_client.return_value = mock_client
 
-            result = list_skills(config)
+            result = await skills_discover(config)
             assert "skills" in result
             assert "count" in result
             assert result["count"] == 1
-            # Verify the client was created and skills_list was called
-            mock_get_client.assert_called_once_with(config, None)
-            mock_client.skills_list.assert_called_once_with(tier=None, include_metadata=True)
+            # Verify the client was created and skills_discover was called
+            mock_get_client.assert_called_once()
+            mock_client.skills_discover.assert_called_once_with(filter="subscribed")
 

tests/test_read_file_path_parsing.py

@@ -1,203 +1,204 @@
 """Unit tests for read_file path parsing with spaces."""
-import pytest
 import shlex
 
+import pytest
+
 
 def parse_read_cmd(read_cmd: str) -> tuple[str, str, int | None, int | None]:
     """
     Parse read command and extract path, command, and optional line numbers.
     This mirrors the logic in tools.py read_file function.
-    
+
     Returns:
         (command, path, start_line, end_line)
     """
     parts = shlex.split(read_cmd.strip())
     if not parts:
         raise ValueError("Empty command")
-    
+
     start_line = None
     end_line = None
-    
+
     if parts[0] in ["cat", "less"]:
         command = parts[0]
         if len(parts) < 2:
             raise ValueError(f"Missing file path for {command}")
-        
+
         # Handle unquoted paths with spaces
         path_parts = []
         remaining_parts = []
-        
+
         for i, part in enumerate(parts[1:], 1):
             try:
                 int(part)
                 remaining_parts = parts[i:]
                 break
             except ValueError:
                 path_parts.append(part)
-        
+
         path = " ".join(path_parts)
-        
+
         if remaining_parts:
             if len(remaining_parts) >= 1:
                 start_line = int(remaining_parts[0])
             if len(remaining_parts) >= 2:
                 end_line = int(remaining_parts[1])
     else:
         command = "cat"
-        
+
         path_parts = []
         remaining_parts = []
-        
+
         for i, part in enumerate(parts):
             try:
                 int(part)
                 remaining_parts = parts[i:]
                 break
             except ValueError:
                 path_parts.append(part)
-        
+
         path = " ".join(path_parts) if path_parts else parts[0]
-        
+
         if remaining_parts:
             if len(remaining_parts) >= 1:
                 start_line = int(remaining_parts[0])
             if len(remaining_parts) >= 2:
                 end_line = int(remaining_parts[1])
-    
+
     return command, path, start_line, end_line
 
 
 class TestReadFilePathParsing:
     """Test suite for read_file path parsing with various scenarios."""
-    
+
     def test_simple_cat(self):
         """Test simple cat command without spaces."""
         cmd, path, start, end = parse_read_cmd("cat /workspace/file.txt")
         assert cmd == "cat"
         assert path == "/workspace/file.txt"
         assert start is None
         assert end is None
-    
+
     def test_simple_less(self):
         """Test simple less command without spaces."""
         cmd, path, start, end = parse_read_cmd("less /workspace/file.txt")
         assert cmd == "less"
         assert path == "/workspace/file.txt"
         assert start is None
         assert end is None
-    
+
     def test_no_command_defaults_to_cat(self):
         """Test that omitting command defaults to cat."""
         cmd, path, start, end = parse_read_cmd("/workspace/file.txt")
         assert cmd == "cat"
         assert path == "/workspace/file.txt"
         assert start is None
         assert end is None
-    
+
     def test_cat_with_start_line(self):
         """Test cat command with start line number."""
         cmd, path, start, end = parse_read_cmd("cat /workspace/file.txt 10")
         assert cmd == "cat"
         assert path == "/workspace/file.txt"
         assert start == 10
         assert end is None
-    
+
     def test_cat_with_start_and_end_lines(self):
         """Test cat command with start and end line numbers."""
         cmd, path, start, end = parse_read_cmd("cat /workspace/file.txt 10 20")
         assert cmd == "cat"
         assert path == "/workspace/file.txt"
         assert start == 10
         assert end == 20
-    
+
     def test_no_command_with_line_numbers(self):
         """Test path without command but with line numbers."""
         cmd, path, start, end = parse_read_cmd("/workspace/file.txt 10 20")
         assert cmd == "cat"
         assert path == "/workspace/file.txt"
         assert start == 10
         assert end == 20
-    
+
     def test_unquoted_path_with_spaces(self):
         """Test unquoted path containing spaces."""
         cmd, path, start, end = parse_read_cmd("less /path/Procare Oct25 cash transactions.md")
         assert cmd == "less"
         assert path == "/path/Procare Oct25 cash transactions.md"
         assert start is None
         assert end is None
-    
+
     def test_unquoted_path_with_one_space(self):
         """Test unquoted path with single space."""
         cmd, path, start, end = parse_read_cmd("cat /workspace/my file.txt")
         assert cmd == "cat"
         assert path == "/workspace/my file.txt"
         assert start is None
         assert end is None
-    
+
     def test_no_command_unquoted_spaces(self):
         """Test path without command containing spaces."""
         cmd, path, start, end = parse_read_cmd("/workspace/my file with spaces.txt")
         assert cmd == "cat"
         assert path == "/workspace/my file with spaces.txt"
         assert start is None
         assert end is None
-    
+
     def test_spaces_with_line_numbers(self):
         """Test unquoted path with spaces AND line numbers."""
         cmd, path, start, end = parse_read_cmd("cat /workspace/my file.txt 1 100")
         assert cmd == "cat"
         assert path == "/workspace/my file.txt"
         assert start == 1
         assert end == 100
-    
+
     def test_spaces_with_start_line_only(self):
         """Test unquoted path with spaces and start line."""
         cmd, path, start, end = parse_read_cmd("less /path/Procare Oct25 transactions.md 50")
         assert cmd == "less"
         assert path == "/path/Procare Oct25 transactions.md"
         assert start == 50
         assert end is None
-    
+
     def test_no_command_spaces_and_lines(self):
         """Test no command with spaces and line numbers."""
         cmd, path, start, end = parse_read_cmd("/workspace/my file.txt 5 15")
         assert cmd == "cat"
         assert path == "/workspace/my file.txt"
         assert start == 5
         assert end == 15
-    
+
     def test_quoted_path_with_spaces(self):
         """Test quoted path with spaces (backwards compatibility)."""
         cmd, path, start, end = parse_read_cmd('cat "/workspace/my file.txt"')
         assert cmd == "cat"
         assert path == "/workspace/my file.txt"
         assert start is None
         assert end is None
-    
+
     def test_quoted_complex_path(self):
         """Test quoted path with complex filename."""
         cmd, path, start, end = parse_read_cmd('less "/path/Procare Oct25 cash transactions.md"')
         assert cmd == "less"
         assert path == "/path/Procare Oct25 cash transactions.md"
         assert start is None
         assert end is None
-    
+
     def test_quoted_path_with_line_numbers(self):
         """Test quoted path with line numbers."""
         cmd, path, start, end = parse_read_cmd('"/workspace/my file.txt" 10 20')
         assert cmd == "cat"
         assert path == "/workspace/my file.txt"
         assert start == 10
         assert end == 20
-    
+
     def test_virtual_parsed_file(self):
         """Test virtual _parsed.{ext}.md file path."""
         cmd, path, start, end = parse_read_cmd("cat /path/file_parsed.pdf.md")
         assert cmd == "cat"
         assert path == "/path/file_parsed.pdf.md"
         assert start is None
         assert end is None
-    
+
     def test_long_tenant_path_with_spaces(self):
         """Test long tenant/user path with spaces in filename."""
         input_cmd = "less /tenant:smooth-flame-13/user:xxx/workspace/ws_personal_b37483e0b292/Procare Oct25 cash transactions 9.28-11.1.25_parsed.xlsx.md"
@@ -206,17 +207,17 @@ def test_long_tenant_path_with_spaces(self):
         assert path == "/tenant:smooth-flame-13/user:xxx/workspace/ws_personal_b37483e0b292/Procare Oct25 cash transactions 9.28-11.1.25_parsed.xlsx.md"
         assert start is None
         assert end is None
-    
+
     def test_empty_command_raises_error(self):
         """Test that empty command raises ValueError."""
         with pytest.raises(ValueError, match="Empty command"):
             parse_read_cmd("")
-    
+
     def test_cat_without_path_raises_error(self):
         """Test that cat without path raises ValueError."""
         with pytest.raises(ValueError, match="Missing file path"):
             parse_read_cmd("cat")
-    
+
     def test_less_without_path_raises_error(self):
         """Test that less without path raises ValueError."""
         with pytest.raises(ValueError, match="Missing file path"):