more tests and minor changes

Author: shabanzd

pkg/storage/memory-lfu.go

@@ -116,10 +116,10 @@ func (lfu *LFUCache) LookUp(ctx context.Context, key string) (*model.Response, e
 			lfu.update(val)
 			node := val.Value.(*LfuNode)
 			response := node.value
-			if (time.Now().Unix() - node.timeStamp) > lfu.staleDuration {
-				response.StaleValue = 0
+			if (time.Now().Unix() - node.timeStamp) >= lfu.staleDuration {
+				response.StaleValue = model.StaleValue
 			} else {
-				response.StaleValue = 1
+				response.StaleValue = model.FreshValue
 			}
 
 			proc <- response

pkg/storage/memory-lfu_test.go

@@ -3,6 +3,7 @@ package storage
 import (
 	"context"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"neurocode.io/cache-offloader/pkg/model"
@@ -172,14 +173,42 @@ func TestLFUCacheCommandExeeeded(t *testing.T) {
 
 func TestLFUStaleStatus(t *testing.T) {
 	oneMegaByte := 1000000.0 / 1024 / 1024
-	lfu := NewLRUCache(oneMegaByte, 0)
+	lfu := NewLFUCache(oneMegaByte, 1)
 	ctx := context.Background()
 
 	lfu.Store(ctx, "1", &model.Response{
 		Status: 100,
 		Body:   []byte{1, 2, 3},
 	})
 
+	resp, _ := lfu.LookUp(ctx, "1")
+	assert.False(t, resp.IsStale())
+
+	time.Sleep(1 * time.Second)
+	resp, _ = lfu.LookUp(ctx, "1")
+	assert.True(t, resp.IsStale())
+}
+
+func TestLFUStaleStatus2(t *testing.T) {
+	oneMegaByte := 1000000.0 / 1024 / 1024
+	lfu := NewLFUCache(oneMegaByte, 1)
+	ctx := context.Background()
+
+	lfu.Store(ctx, "1", &model.Response{
+		Status: 100,
+		Body:   []byte{1, 2, 3},
+	})
+
+	time.Sleep(1 * time.Second)
+
 	resp, _ := lfu.LookUp(ctx, "1")
 	assert.True(t, resp.IsStale())
+
+	lfu.Store(ctx, "1", &model.Response{
+		Status: 100,
+		Body:   []byte{1, 2, 3},
+	})
+
+	resp, _ = lfu.LookUp(ctx, "1")
+	assert.False(t, resp.IsStale())
 }

pkg/storage/memory-lru.go

@@ -94,9 +94,9 @@ func (lru *LRUCache) LookUp(ctx context.Context, key string) (*model.Response, e
 			node := value.Value.(*LRUNode)
 			response := node.value
 			if (time.Now().Unix() - node.timeStamp) >= lru.staleDuration {
-				response.StaleValue = 0
+				response.StaleValue = model.StaleValue
 			} else {
-				response.StaleValue = 1
+				response.StaleValue = model.FreshValue
 			}
 
 			proc <- response

pkg/storage/memory-lru_test.go

@@ -3,6 +3,7 @@ package storage
 import (
 	"context"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"neurocode.io/cache-offloader/pkg/model"
@@ -193,14 +194,42 @@ func TestLRUCacheCommandExeeeded(t *testing.T) {
 
 func TestLRUStaleStatus(t *testing.T) {
 	oneMegaByte := 1000000.0 / 1024 / 1024
-	lru := NewLRUCache(oneMegaByte, 0)
+	lfu := NewLRUCache(oneMegaByte, 1)
 	ctx := context.Background()
 
-	lru.Store(ctx, "1", &model.Response{
+	lfu.Store(ctx, "1", &model.Response{
 		Status: 100,
 		Body:   []byte{1, 2, 3},
 	})
 
-	resp, _ := lru.LookUp(ctx, "1")
+	resp, _ := lfu.LookUp(ctx, "1")
+	assert.False(t, resp.IsStale())
+
+	time.Sleep(1 * time.Second)
+	resp, _ = lfu.LookUp(ctx, "1")
 	assert.True(t, resp.IsStale())
 }
+
+func TestLRUStaleStatus2(t *testing.T) {
+	oneMegaByte := 1000000.0 / 1024 / 1024
+	lfu := NewLRUCache(oneMegaByte, 1)
+	ctx := context.Background()
+
+	lfu.Store(ctx, "1", &model.Response{
+		Status: 100,
+		Body:   []byte{1, 2, 3},
+	})
+
+	time.Sleep(1 * time.Second)
+
+	resp, _ := lfu.LookUp(ctx, "1")
+	assert.True(t, resp.IsStale())
+
+	lfu.Store(ctx, "1", &model.Response{
+		Status: 100,
+		Body:   []byte{1, 2, 3},
+	})
+
+	resp, _ = lfu.LookUp(ctx, "1")
+	assert.False(t, resp.IsStale())
+}