Skip to content

Commit 9e25cd2

Browse files
authored
Merge pull request #397 from netwrix/dev
fix normalization of doc review output
2 parents f16d89d + e33c994 commit 9e25cd2

2 files changed

Lines changed: 42 additions & 42 deletions

File tree

.github/workflows/claude-documentation-reviewer.yml

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -271,20 +271,28 @@ jobs:
271271
i += 1
272272
continue
273273
274-
# Convert bold-closed format: **Line N: title** + sub-bullets → **Line N:** title. parts.
275-
m = re.match(r'^\*\*(Line \d+:.*?)\*\*\s*$', line)
274+
# Convert bold-closed format: **Line N: label.** + continuation → **Line N:** label. continuation.
275+
m = re.match(r'^\*\*(Line \d+):\s*(.*?)\*\*\s*$', line)
276276
if m:
277-
title = m.group(1).rstrip('.')
277+
lineref = m.group(1)
278+
label = m.group(2).rstrip('.')
278279
i += 1
279-
parts = []
280-
while i < len(src) and re.match(r'^\s*[-*]\s+', src[i]):
281-
sub = re.sub(r'^\s*[-*]\s+', '', src[i])
282-
sub = re.sub(r'^(Issue|Fix|Description|Suggested change|Current):\s*', '', sub, flags=re.IGNORECASE)
283-
if sub.strip():
284-
parts.append(sub.strip().rstrip('.'))
285-
i += 1
286-
combined = f'**{title}. {". ".join(parts)}.**' if parts else f'**{title}.**'
287-
result.append(combined)
280+
parts = [label] if label else []
281+
while i < len(src):
282+
next_line = src[i]
283+
if re.match(r'^\s*[-*]\s+', next_line):
284+
sub = re.sub(r'^\s*[-*]\s+', '', next_line)
285+
sub = re.sub(r'^(Issue|Fix|Description|Suggested change|Current|Should):\s*', '', sub, flags=re.IGNORECASE)
286+
if sub.strip():
287+
parts.append(sub.strip().rstrip('.'))
288+
i += 1
289+
elif next_line.strip() and not re.match(r'^\*\*(Line \d+)', next_line) and not re.match(r'^#+\s', next_line):
290+
parts.append(next_line.strip().rstrip('.'))
291+
i += 1
292+
else:
293+
break
294+
desc = '. '.join(parts).rstrip('.')
295+
result.append(f'**{lineref}:** {desc}.' if desc else f'**{lineref}:**')
288296
continue
289297
290298
# Collapse numbered list items with sub-bullets (e.g. 1. **Issue title**: desc\n - Current: ...\n - Fix: ...)

docs/passwordsecure/9.1/msp_system.md

Lines changed: 22 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,62 +6,54 @@ sidebar_position: 30
66

77
# MSP System
88

9-
To ensure optimal operation, we recommend that the following hardware resources are made available:
9+
For optimal operation, make the following hardware resources available.
1010

1111
## Microsoft SQL Server
1212

13-
The following system requirements are the minimum system requirements and should manage around 10
14-
customers with less than 20 users each.
13+
These are the minimum system requirements for managing approximately 10 customers with fewer than 20 users each.
1514

16-
- Windows Server 2016 (or newer)
17-
- MSSQL Server 2014 (or newer)
18-
- 4 CPU’s
15+
- Windows Server 2016 or newer
16+
- MSSQL Server 2014 or newer
17+
- 4 CPUs
1918
- 16 GB RAM
20-
- min. 100 GB HDD
19+
- 100 GB HDD minimum
2120

2221
:::warning
23-
Please note, that using a SQL Server with Express edition is not recommended because of
24-
diverse limitations there.
22+
SQL Server Express edition is not recommended due to its limitations.
2523
:::
2624

25+
As your customer count grows, add the following resources for every 200 additional users:
2726

28-
If your customer's count is growing over time, you should add every 200 users a minimum of at least:
29-
30-
- 2 CPU’s
27+
- 2 CPUs
3128
- 8 GB RAM
3229

3330
## Application Server
3431

35-
The following system requirements are the minimum system requirements and should manage around 10
36-
customers with 20 users each.
32+
These are the minimum system requirements for managing approximately 10 customers with 20 users each.
3733

38-
- Windows Server 2016 (or newer)
39-
- 4 CPU’s
34+
- Windows Server 2016 or newer
35+
- 4 CPUs
4036
- 16 GB RAM
41-
- min. 50 GB HDD
37+
- 50 GB HDD minimum
4238
- .NET Framework 4.8
4339

44-
If your customer's count is growing over time, you should add every 200 users a minimum of at least:
40+
As your customer count grows, add the following resources for every 200 additional users:
4541

4642
- 1 CPU
4743
- 4 GB RAM
4844

49-
RECOMMENDED: Currently, we suggest you use an application server to handle a max of about 100
50-
customers. So if you reach 100 customers, you should set up a second Application Server or use some
51-
sort of load balancing between the application servers.
45+
:::tip
46+
Configure each application server to handle a maximum of 100 customers. When you reach that limit, set up a second application server or implement load balancing across your application servers.
47+
:::
5248

5349
:::warning
54-
Every additional 1000 users an additional Web-Endpoint - incl. loadbalancing - is
55-
recommended
50+
Add an additional Web Endpoint — including load balancing — for every 1,000 additional users.
5651
:::
5752

58-
5953
:::warning
60-
Every additional 100 customers/1000 users an additional Application Server - incl.
61-
loadbalancing - is recommended.
54+
Add an additional application server — including load balancing — for every 100 additional customers or 1,000 additional users.
6255
:::
6356

64-
65-
NOTE: Please note that individual variables - like the number of passwords per user - will affect
66-
performance. Especially for MSP-Systems it is required to monitor performance continuously, and add
67-
additional resources on demand.
57+
:::note
58+
Individual variables, such as the number of passwords per user, affect performance. For MSP systems, monitor performance continuously and add resources as needed.
59+
:::

0 commit comments

Comments
 (0)