upsd PID check and config loading in wrong order

[Thermi]

upsd version 2.7.4

Please order the check correctly. Right now, the STATEPATH in upsd.conf doesn't influence the checking of the PID file, although it should. The default path is /var/state/nut/, which is a permanent, not a volatile directory, so the PID file persists between reboots, if nut is shutdown unclean.

See

nut/server/upsd.c

Line 1220 in 241848c

if (sendsignalfn(pidfn, 0) == 0) {

vs

nut/server/upsd.c

Line 1253 in 241848c

load_upsdconf(0); /* 0 = initial */

[jimklimov]

Problem could be somewhat alleviated by recent checks that a PID refers to expected process name, which evolved across 2.8.x releases.