Add support for platform and serial update on an existing device

Author: dgarros

netbox_onboarding/onboard.py

@@ -429,22 +429,17 @@ def ensure_device_instance(self, default_status=PLUGIN_SETTINGS["default_device_
           default_status (str) : status assigned to a new device by default.
         """
         try:
-            device = Device.objects.get(
-                name=self.netdev.hostname,
-                device_type=self.device_type,
-                device_role=self.netdev.ot.role,
-                site=self.netdev.ot.site,
-            )
+            device = Device.objects.get(name=self.netdev.hostname, site=self.netdev.ot.site)
         except Device.DoesNotExist:
             device = Device.objects.create(
                 name=self.netdev.hostname,
+                site=self.netdev.ot.site,
                 device_type=self.device_type,
                 device_role=self.netdev.ot.role,
-                platform=self.netdev.ot.platform,
-                site=self.netdev.ot.site,
                 status=default_status,
             )
 
+        device.platform = self.netdev.ot.platform
         device.serial = self.netdev.serial_number
         device.save()
 

netbox_onboarding/tests/test_onboard.py

@@ -122,9 +122,32 @@ def test_ensure_device_instance_not_exist(self):
         nbk.ensure_device_instance(default_status="planned")
         self.assertIsInstance(nbk.device, Device)
         self.assertEqual(nbk.device.status, "planned")
+        self.assertEqual(nbk.device.platform, self.platform1)
         self.assertEqual(nbk.device, nbk.netdev.ot.created_device)
         self.assertEqual(nbk.device.serial, "123456")
 
+    def test_ensure_device_instance_exist(self):
+        """Verify ensure_device_instance function."""
+
+        device = Device.objects.create(
+            name=self.ndk2.hostname,
+            site=self.site1,
+            device_type=self.device_type1,
+            device_role=self.device_role1,
+            status="planned",
+            serial="987654",
+        )
+
+        nbk = NetboxKeeper(self.ndk2)
+        nbk.netdev.ot = self.onboarding_task3
+        self.assertEqual(nbk.device, None)
+        nbk.ensure_device_instance(default_status="active")
+        self.assertIsInstance(nbk.device, Device)
+        self.assertEqual(nbk.device.status, "planned")
+        self.assertEqual(nbk.device.platform, self.platform1)
+        self.assertEqual(nbk.device, device)
+        self.assertEqual(nbk.device.serial, "123456")
+
     def test_ensure_interface_not_exist(self):
         """Verify ensure_interface function when the interface do not exist."""
         nbk = NetboxKeeper(self.ndk2)