refactor: renamed milestone command to release

Fixed issue where the sync could break the repo for a brief moment

Author: Tbaile

README.md

@@ -189,7 +189,7 @@ While most values are self-explanatory, there are a few that you need to manuall
 - `APP_URL`: The full URL where the application is reached from, while most of the functionalities will work with a
   wrong value, the url generation is based off this value.
 - `FILESYSTEM_DISK`: Disk to use during production, works same as development, more info in the development setup.
-- `REPOSITORY_MILESTONE_TOKEN`: Token used to trigger from remote the milestone creation, you can set this to a random
+- `REPOSITORY_RELEASE_TOKEN`: Token used to trigger from remote a clean release, you can set this to a random
   value, it's used to avoid unwanted requests.
 - `NIGHTWATCH_TOKEN`: In case you want to enable nightwatch stats, you need to set this to the token provided by
   nightwatch.
@@ -358,26 +358,25 @@ be provided the folder that are snapshotted and which one is currently being ser
 php artisan repository:snapshots {repository_name}
 ```
 
-### Milestone release
+### Fresh release
 
-A Milestone Release is a process that wipes all the snapshots of a repository and then creates one with the latest sync.
+A Fresh Release is a process that wipes all the snapshots of a repository and then creates one with the latest sync.
 This is useful when you want to release a new version of a repository, or when you want to force the release of a
 specific set of packages.
 
-To trigger a milestone release, this can be done by both of the following:
-
+To trigger a fresh release, this can be done by both of the following:
 - CLI
 
 ```bash
-php artisan repository:milestone {repository_name}
+php artisan repository:release {repository_name}
 ```
 
 - CURL
 
-Additional authentication must be provided, the token is set in the `.env` file under the `REPOSITORY_MILESTONE_TOKEN`.
+Additional authentication must be provided, the token is set in the `.env` file under the `REPOSITORY_RELEASE_TOKEN`.
 
 ```bash
-curl -X POST -H Accept:application/json -H Authorization:Bearer <token> <url>/repository/<repository_name>/milestone
+curl -X POST -H Accept:application/json -H Authorization:Bearer <token> <url>/repository/<repository_name>/release
 ```
 
 ## List of behaviors when faulty packages get accidentally distributed

…Console/Commands/MilestoneRepository.php …p/Console/Commands/ReleaseRepository.phpapp/Console/Commands/MilestoneRepository.php renamed to app/Console/Commands/ReleaseRepository.php app/Console/Commands/MilestoneRepository.php renamed to app/Console/Commands/ReleaseRepository.php

@@ -2,27 +2,27 @@
 
 namespace App\Console\Commands;
 
-use App\Jobs\MilestoneRelease;
+use App\Jobs\Release;
 use App\Models\Repository;
 use Illuminate\Console\Command;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Throwable;
 
-class MilestoneRepository extends Command
+class ReleaseRepository extends Command
 {
     /**
      * The name and signature of the console command.
      *
      * @var string
      */
-    protected $signature = 'repository:milestone {repository}';
+    protected $signature = 'repository:release {repository}';
 
     /**
      * The console command description.
      *
      * @var string
      */
-    protected $description = 'Dispatch a milestone reset job for the given repository.';
+    protected $description = 'Dispatch a release job for the given repository.';
 
     /**
      * Execute the console command.
@@ -33,8 +33,8 @@ public function handle(): void
     {
         try {
             $repository = Repository::where('name', $this->argument('repository'))->firstOrFail();
-            MilestoneRelease::dispatch($repository);
-            $this->info("Milestone release for $repository->name dispatched.");
+            Release::dispatch($repository);
+            $this->info("Release for $repository->name dispatched.");
         } catch (ModelNotFoundException) {
             $this->fail("Repository '{$this->argument('repository')}' not found.");
         }

app/Http/Middleware/MilestoneAuth.php app/Http/Middleware/ReleaseAuth.phpapp/Http/Middleware/MilestoneAuth.php renamed to app/Http/Middleware/ReleaseAuth.php

@@ -7,17 +7,17 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
 
-class MilestoneAuth
+class ReleaseAuth
 {
     /**
      * Using the Authorization header to authenticate the user, the token is passed as a Bearer token.
-     * Check against the configuration milestone_token to allow the request.
+     * Check against the configuration release_token to allow the request.
      *
      * @param  Closure(Request): (Response)  $next
      */
     public function handle(Request $request, Closure $next): Response
     {
-        if ($request->header('Authorization') !== 'Bearer '.config('repositories.milestone_token')) {
+        if ($request->header('Authorization') !== 'Bearer '.config('repositories.release_token')) {
             throw new UnauthorizedHttpException('Bearer', 'Unauthenticated');
         }
 

app/Jobs/DeleteSnapshot.php

@@ -0,0 +1,37 @@
+<?php
+
+//
+// Copyright (C) 2026 Nethesis S.r.l.
+// SPDX-License-Identifier: AGPL-3.0-or-later
+//
+
+namespace App\Jobs;
+
+use Illuminate\Bus\Batchable;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Queue\Queueable;
+use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Storage;
+
+class DeleteSnapshot implements ShouldQueue
+{
+    use Batchable, Queueable;
+
+    /**
+     * Delete a snapshot directory.
+     */
+    public function __construct(public readonly string $directory) {}
+
+    /**
+     * Execute the job.
+     */
+    public function handle(): void
+    {
+        if ($this->batch()?->cancelled()) {
+            return;
+        }
+
+        Log::debug("Deleting snapshot directory: {$this->directory}");
+        Storage::deleteDirectory($this->directory);
+    }
+}

app/Jobs/MilestoneRelease.php

@@ -0,0 +1,96 @@
+<?php
+
+//
+// Copyright (C) 2026 Nethesis S.r.l.
+// SPDX-License-Identifier: AGPL-3.0-or-later
+//
+
+namespace App\Jobs;
+
+use App\Models\Repository;
+use Carbon\Carbon;
+use Illuminate\Bus\Batch;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Queue\Queueable;
+use Illuminate\Support\Facades\Bus;
+use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Storage;
+use Throwable;
+
+class Release implements ShouldQueue
+{
+    use Queueable;
+
+    /**
+     * Sync the release.
+     */
+    public function __construct(public readonly Repository $repository) {}
+
+    /**
+     * Execute the job.
+     */
+    public function handle(): void
+    {
+        Log::debug("Releasing {$this->repository->name}.");
+
+        // Sync the repository to create a fresh snapshot
+        SyncRepository::dispatchSync($this->repository);
+
+        // Get all snapshot directories and filter to only valid snapshot timestamps
+        $allDirectories = Storage::directories($this->repository->snapshotDir());
+        $snapshots = collect($allDirectories)->filter(function ($dir) {
+            $basename = basename($dir);
+            try {
+                Carbon::createFromFormat(DATE_ATOM, $basename);
+
+                return true;
+            } catch (\Exception $e) {
+                return false;
+            }
+        })->sortByDesc(function ($dir) {
+            return Carbon::createFromFormat(DATE_ATOM, basename($dir));
+        })->values();
+
+        if ($snapshots->isEmpty()) {
+            Log::warning("No valid snapshots found for {$this->repository->name}.");
+
+            return;
+        }
+
+        // Freeze to the most recent snapshot
+        $lastSnapshot = $snapshots->first();
+        $this->repository->freeze = basename($lastSnapshot);
+        $this->repository->save();
+        Log::info("Froze {$this->repository->name} to snapshot: {$this->repository->freeze}");
+
+        // Prepare deletion jobs for all other snapshots
+        $snapshotsToDelete = $snapshots->slice(1);
+
+        if ($snapshotsToDelete->isEmpty()) {
+            Log::info("No snapshots to delete for {$this->repository->name}.");
+
+            return;
+        }
+
+        $deletionJobs = $snapshotsToDelete->map(fn ($dir) => new DeleteSnapshot($dir))->all();
+
+        // Dispatch batch with unfreeze on success
+        Bus::batch($deletionJobs)
+            ->then(function (Batch $batch) {
+                $repo = $this->repository->fresh();
+                $repo->freeze = null;
+                $repo->save();
+                Log::info("Repository {$repo->name} unfrozen after successful cleanup.");
+            })
+            ->catch(function (Batch $batch, Throwable $e) {
+                Log::error("Deletion batch failed for {$this->repository->name}", [
+                    'batch_id' => $batch->id,
+                    'error' => $e->getMessage(),
+                ]);
+            })
+            ->name("Release cleanup for {$this->repository->name}")
+            ->dispatch();
+
+        Log::debug("Release completed for {$this->repository->name}.");
+    }
+}

app/Jobs/Release.php

@@ -13,7 +13,7 @@
     )
     ->withMiddleware(function (Middleware $middleware) {
         $middleware->validateCsrfTokens(except: [
-            '/repository/*/milestone',
+            '/repository/*/release',
         ]);
     })
     ->withExceptions(function (Exceptions $exceptions) {

bootstrap/app.php

@@ -22,7 +22,7 @@
     'snapshots' => env('REPOSITORY_BASE_FOLDER', 'snapshots'),
 
     /*
-     * Milestone release authentication token
+     * Fresh release authentication token
      */
-    'milestone_token' => env('REPOSITORY_MILESTONE_TOKEN'),
+    'release_token' => env('REPOSITORY_RELEASE_TOKEN'),
 ];

config/repositories.php

@@ -30,7 +30,7 @@
         <env name="QUEUE_CONNECTION" value="sync"/>
         <env name="SESSION_DRIVER" value="array"/>
         <env name="TELESCOPE_ENABLED" value="false"/>
-        <env name="REPOSITORY_MILESTONE_TOKEN" value="testing" />
+        <env name="REPOSITORY_RELEASE_TOKEN" value="testing" />
         <env name="NETIFYD_API_KEY" value="key" />
     </php>
 </phpunit>

phpunit.xml

@@ -4,8 +4,8 @@
 use App\Http\Middleware\CommunityLicenceCheck;
 use App\Http\Middleware\EnterpriseLicenceCheck;
 use App\Http\Middleware\ForceBasicAuth;
-use App\Http\Middleware\MilestoneAuth;
-use App\Jobs\MilestoneRelease;
+use App\Http\Middleware\ReleaseAuth;
+use App\Jobs\Release;
 use App\Models\Repository;
 use Illuminate\Support\Facades\Route;
 use Laravel\Nightwatch\Http\Middleware\Sample;
@@ -14,11 +14,11 @@
     return view('welcome');
 });
 
-Route::middleware(MilestoneAuth::class)
-    ->post('/repository/{repository:name}/milestone', function (Repository $repository) {
-        MilestoneRelease::dispatch($repository);
+Route::middleware(ReleaseAuth::class)
+    ->post('/repository/{repository:name}/release', function (Repository $repository) {
+        Release::dispatch($repository);
 
-        return response()->json(['message' => 'Milestone release job dispatched.']);
+        return response()->json(['message' => 'Release job dispatched.']);
     });
 
 Route::middleware([ForceBasicAuth::class, Sample::rate(0)])->group(function () {