Complete Type test

Author: MarioBlazek

tests/Core/FieldType/EnhancedBinaryFile/TypeTest.php

@@ -127,4 +127,46 @@ public function testValidateWithMineTypesFromConfig()
 
         $this->type->validate($fieldDefinition, $value);
     }
+
+    public function testValidateFieldSettingsWithEmptyArray()
+    {
+        $result = $this->type->validateFieldSettings([]);
+        $this->assertTrue(is_array($result));
+        $this->assertTrue(empty($result));
+    }
+
+    public function testValidateFieldSettingsWithBool()
+    {
+        $result = $this->type->validateFieldSettings(false);
+        $this->assertTrue(is_array($result));
+        $this->assertFalse(empty($result));
+        $this->assertEquals(new ValidationError('Field settings must be in form of an array'), $result[0]);
+    }
+
+    public function testValidateFieldSettingsWithFieldSettings()
+    {
+        $fieldSettings = [
+            "allowedTypes" => [],
+            "some_settings" => [],
+        ];
+        $result = $this->type->validateFieldSettings($fieldSettings);
+        $this->assertTrue(is_array($result));
+        $this->assertFalse(empty($result));
+        $this->assertEquals(
+            new ValidationError(
+                "Setting '%setting%' is unknown",
+                null,
+                ['setting' => 'some_settings']
+            ),
+            $result[0]
+        );
+    }
+
+    public function testFromHash()
+    {
+        $result = $this->type->fromHash([]);
+
+        $this->assertInstanceOf(Value::class, $result);
+        $this->assertEquals(new Value(), $result);
+    }
 }

tests/Form/FieldTypeHandler/EnhancedFileTest.php

@@ -3,19 +3,20 @@
 namespace Netgen\Bundle\EnhancedBinaryFileBundle\Tests\Form\FieldTypeHandler;
 
 use eZ\Publish\Core\MVC\ConfigResolverInterface;
+use eZ\Publish\Core\Repository\Values\ContentType\FieldDefinition;
 use Netgen\Bundle\EnhancedBinaryFileBundle\Core\FieldType\EnhancedBinaryFile\Value;
 use Netgen\Bundle\EnhancedBinaryFileBundle\Form\FieldTypeHandler\EnhancedFile;
 use Netgen\Bundle\EzFormsBundle\Form\FieldTypeHandler;
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\Finder\SplFileInfo;
+use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\HttpFoundation\File\UploadedFile;
 
 class EnhancedFileTest extends TestCase
 {
     /**
      * @var EnhancedFile
      */
-    protected  $handler;
+    protected $handler;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
@@ -55,4 +56,12 @@ public function testConvertFieldValueFromFormWithFile()
         $this->assertEquals($file->getSize(), $result['fileSize']);
         $this->assertEquals($file->getClientMimeType(), $result['mimeType']);
     }
+
+    public function testBuildFieldCreateForm()
+    {
+        $formBuilder = $this->createMock(FormBuilderInterface::class);
+        $fieldDefinition = new FieldDefinition();
+        $lang = 'eng_US';
+        $this->handler->buildFieldCreateForm($formBuilder, $fieldDefinition, $lang);
+    }
 }