From 95ba0877314c55f74a7905e01d656cea7f1bd365 Mon Sep 17 00:00:00 2001 From: Christian Tarabusi Date: Thu, 31 Mar 2016 16:38:48 +0200 Subject: [PATCH 1/2] The single quote breaks the strings in Android. We should escape them --- lib/babelish/csv2android.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/babelish/csv2android.rb b/lib/babelish/csv2android.rb index 8452364..d14745f 100644 --- a/lib/babelish/csv2android.rb +++ b/lib/babelish/csv2android.rb @@ -16,7 +16,8 @@ def language_filepaths(language) def process_value(row_value, default_value) value = super(row_value, default_value) - # if the value begins and ends with a quote we must leave them unescapted + value.gsub!(/'/, {"'" => "\\'"}) # escape single quote only for Android + # if the value begins and ends with a quote we must leave them unescaped if value.size > 4 && value[0, 2] == "\\\"" && value[value.size - 2, value.size] == "\\\"" value[0, 2] = "\"" value[value.size - 2, value.size] = "\"" From bc97884503b3155015c73e3c22478053aa035706 Mon Sep 17 00:00:00 2001 From: Christian Tarabusi Date: Thu, 31 Mar 2016 16:42:49 +0200 Subject: [PATCH 2/2] Removed unnecessary curly braces --- lib/babelish/csv2android.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/babelish/csv2android.rb b/lib/babelish/csv2android.rb index d14745f..916be21 100644 --- a/lib/babelish/csv2android.rb +++ b/lib/babelish/csv2android.rb @@ -16,7 +16,7 @@ def language_filepaths(language) def process_value(row_value, default_value) value = super(row_value, default_value) - value.gsub!(/'/, {"'" => "\\'"}) # escape single quote only for Android + value.gsub!(/'/, "'" => "\\'") # escape single quote only for Android # if the value begins and ends with a quote we must leave them unescaped if value.size > 4 && value[0, 2] == "\\\"" && value[value.size - 2, value.size] == "\\\"" value[0, 2] = "\""