Skip to content

fix: clear Reliable/Unreliable consistency label with both metrics (fixes #149) #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nerdCopter merged 2 commits into from
May 21, 2026
Merged

fix: clear Reliable/Unreliable consistency label with both metrics (fixes #149) #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a573d7
fix: report actual failing condition(s) in consistency warning (#149)
nerdCopter May 21, 2026
f79f39b
fix: always show both Consistency and CV metrics (#149)
nerdCopter May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions src/data_analysis/optimal_p_estimation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,27 +503,37 @@ impl OptimalPAnalysis {

// Compact header - axis name and basic info
output.push_str(&format!(
"{}: Td={:.1}ms (target {}, {:+.0}% dev, windows={}), Noise={}, Consistency={:.0}%\n",
"{}: Td={:.1}ms (target {}, {:+.0}% dev, windows={}), Noise={}\n",
axis_name,
self.td_stats.mean_ms,
target_display,
self.td_deviation_percent,
self.td_stats.num_samples,
self.noise_level.name(),
self.td_stats.consistency * 100.0
));

// Warning for low consistency (inline)
if !self.td_stats.is_consistent() {
let cv_percent = self
.td_stats
.coefficient_of_variation
.map_or(0.0, |cv| cv * 100.0);
output.push_str(&format!(
" ⚠ Low consistency (CV={:.1}%) — unreliable (>{:.0}%)\n",
cv_percent,
TD_COEFFICIENT_OF_VARIATION_MAX * 100.0
));
// Reliability line — always shown with both metrics
{
let cv_str = self.td_stats.coefficient_of_variation.map_or_else(
|| "CV=N/A".to_string(),
|cv| {
format!(
"CV={:.1}% (≤{:.0}%)",
cv * 100.0,
TD_COEFFICIENT_OF_VARIATION_MAX * 100.0,
)
},
);
let cons_str = format!(
"Consistency={:.0}% (≥{:.0}%)",
self.td_stats.consistency * 100.0,
TD_CONSISTENCY_MIN_THRESHOLD * 100.0,
);
if self.td_stats.is_consistent() {
output.push_str(&format!(" Reliable: {cons_str}, {cv_str}\n"));
} else {
output.push_str(&format!(" Unreliable: {cons_str}, {cv_str}\n"));
}
}

// Compact recommendation
Expand Down
39 changes: 22 additions & 17 deletions src/plot_functions/plot_step_response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use crate::constants::{
FINAL_NORMALIZED_STEADY_STATE_TOLERANCE, LINE_WIDTH_PLOT,
LOW_AUTHORITY_SETPOINT_THRESHOLD_DEG_S, POST_AVERAGING_SMOOTHING_WINDOW, RESPONSE_LENGTH_S,
STEADY_STATE_END_S, STEADY_STATE_START_S, TD_COEFFICIENT_OF_VARIATION_MAX,
TD_CONSISTENCY_MIN_THRESHOLD,
};
use crate::data_analysis::calc_step_response; // For average_responses and moving_average_smooth_f64
use crate::data_analysis::optimal_p_estimation::{OptimalPAnalysis, PRecommendation};
Expand Down Expand Up @@ -629,28 +630,32 @@ pub fn plot_step_response(
stroke_width: 0,
});

// Consistency — always shown; orange warning when poor
// Reliability — always shown with both metrics; orange when poor
{
let cv_percent = analysis
.td_stats
.coefficient_of_variation
.map_or(0.0, |cv| cv * 100.0);
let consistency_pct =
(analysis.td_stats.consistency * 100.0).round() as u32;
let (cons_label, cons_color) = if !analysis.td_stats.is_consistent() {
(
let cv_str = analysis.td_stats.coefficient_of_variation.map_or_else(
|| "CV=N/A".to_string(),
|cv| {
format!(
" Consistency: {}% (CV={:.1}%) — unreliable (>{:.0}%)",
consistency_pct,
cv_percent,
TD_COEFFICIENT_OF_VARIATION_MAX * 100.0
),
COLOR_OPTIMAL_P_WARNING,
"CV={:.1}% (≤{:.0}%)",
cv * 100.0,
TD_COEFFICIENT_OF_VARIATION_MAX * 100.0,
)
},
);
let cons_str = format!(
"Consistency={:.0}% (≥{:.0}%)",
analysis.td_stats.consistency * 100.0,
TD_CONSISTENCY_MIN_THRESHOLD * 100.0,
);
let (cons_label, cons_color) = if analysis.td_stats.is_consistent() {
(
format!(" Reliable: {cons_str}, {cv_str}"),
COLOR_OPTIMAL_P_TEXT,
)
} else {
(
format!(" Consistency: {}%", consistency_pct),
COLOR_OPTIMAL_P_TEXT,
format!(" Unreliable: {cons_str}, {cv_str}"),
COLOR_OPTIMAL_P_WARNING,
)
};
series.push(PlotSeries {
Expand Down
Loading