Skip to content

Minor nitpick: Consider f64 precision in setpoint derivative calculation #116

@coderabbitai

Description

@coderabbitai

Context
This issue tracks a minor precision consideration identified during PR #114 review.

Description
In src/plot_functions/plot_setpoint_derivative.rs (lines 70-75), setpoint values are converted from f64 → f32 for derivative calculation, then back to f64 for plotting. This introduces minor precision loss.

Current Status
Acceptable for current use case - The precision loss is negligible for visualization purposes, as this is used for plotting/graphical output rather than numerical analysis.

Future Consideration
If higher precision becomes necessary in the future, this could be addressed by updating derivative::calculate_derivative to accept f64 directly. However, this would require a larger refactor of the derivative calculation module.

Linked PR

Priority
Low - This is a minor nitpick that does not affect current functionality or accuracy for visualization purposes.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions