Remove premature autoclose

lets rather assume the passed authenticated client can be always closed for now.

Author: FlorentinD

graphdatascience/arrow_client/v1/gds_arrow_client.py

@@ -24,11 +24,15 @@ class GdsArrowClient:
     def __init__(
         self,
         flight_client: AuthenticatedArrowClient,
-        auto_close: bool = True,
     ):
-        """Creates a new GdsArrowClient instance."""
+        """Creates a new GdsArrowClient instance.
+
+        Parameters
+        ----------
+        flight_client : AuthenticatedArrowClient
+            The authenticated flight client to use for communication with the GDS server. Ownership of the client is transferred to this GdsArrowClient.
+        """
         self._flight_client = flight_client
-        self._auto_close = auto_close
         self._logger = logging.getLogger("gds_arrow_client")
 
     def get_node_properties(
@@ -553,8 +557,7 @@ def __exit__(
         self.close()
 
     def close(self) -> None:
-        if self._auto_close:
-            self._flight_client.close()
+        self._flight_client.close()
 
     @staticmethod
     def _sanitize_arrow_table(arrow_table: Table) -> Table:

graphdatascience/tests/unit/arrow_client/V1/test_gds_arrow_client.py

@@ -127,8 +127,7 @@ def gds_client(flight_server: FlightServer) -> Generator[GdsArrowClient, None, N
         ArrowInfo(f"localhost:{flight_server.port}", True, True, ["v1"]),
         UsernamePasswordAuthentication("user", "password"),
     ) as arrow_client:
-        with GdsArrowClient(arrow_client, auto_close=False) as gds_client:
-            yield gds_client
+        yield GdsArrowClient(arrow_client)
 
 
 @pytest.fixture()
@@ -137,8 +136,7 @@ def flaky_gds_client(flaky_flight_server: FlakyFlightServer) -> Generator[GdsArr
         ArrowInfo(f"localhost:{flaky_flight_server.port}", True, True, ["v1"]),
         UsernamePasswordAuthentication("user", "password"),
     ) as arrow_client:
-        with GdsArrowClient(arrow_client, auto_close=False) as gds_client:
-            yield gds_client
+        yield GdsArrowClient(arrow_client)
 
 
 def test_create_graph_with_defaults(flight_server: FlightServer, gds_client: GdsArrowClient) -> None: